-
Notifications
You must be signed in to change notification settings - Fork 353
Open
Labels
proposalEnhancement idea or proposalEnhancement idea or proposal
Description
What motivated this proposal?
Gives the ability to add custom labels for the NACK pod, as it is already given for annotations.
This will allow the client to integrate with custom controllers and tools.
What is the proposed change?
Make it available, as it has already done with the pod annotations
https://github.com/nats-io/k8s/blob/main/helm/charts/nack/templates/deployment-jetstream-controller.yml#L25
# helm/charts/nack/templates/deployment-jetstream-controller.yml
...
template:
metadata:
{{- if .Values.podAnnotations }}
annotations:
{{- toYaml .Values.podAnnotations | nindent 8 }}
{{- end }}
labels:
app: {{ template "jsc.name" . }}
chart: {{ .Chart.Name }}-{{ .Chart.Version | replace "+" "_" }}
{{- if .Values.podLabels }}
{{- toYaml .Values.podLabels | nindent 10 }}
{{- end }}
...
Who benefits from this change?
No response
What alternatives have you evaluated?
Patch the pod/replicaset with the custom label
Metadata
Metadata
Assignees
Labels
proposalEnhancement idea or proposalEnhancement idea or proposal