Should .json files written by `audit gather` end with newline?

[alexbozhenko]

Proposed change

E.g. these files:
clusters/*/*/jetstream_info/*.json
are not ending in a newline.

Do I understand correctly that, according to standards, text files should always end in a newline?
https://www.baeldung.com/linux/files-end-with-newlines#newlines-at-the-end-of-the-file

Use case

I initially thought that it was breaking jq in some scenarios, but it looks like it is not the case.

Still, should probably do the right thing for the sake of consistency? (at least wc -l counts lines in such files incorrectly)

Contribution

I can.

[ripienaar]

The purpose of these files isn’t to be user read so happy as they are

[alexbozhenko]

Exactly. Humans can tolerate this.
But it is inconsistent:
https://gist.github.com/alexbozhenko/32bb824067e58ed0631cfa9124bb2e63
Some of the text files end with 0x0a (\n), some with 0x7d (})

And it may break some tooling.

That's because this adds a newline https://pkg.go.dev/encoding/json#Encoder.Encode
and this does not:
https://pkg.go.dev/encoding/json#Indent

[ripienaar]

What doesn’t work?

This seems like an incredibly minor thing that is of no consequence.

Let’s please focus our efforts on things that matter. One day when literally all bugs are squashed and all features implemented we can spend our days on things like this which doesn’t impact anything.