🧽 Clean up templates by leveraging restartPolicy and imagePullPolicy defaults

Author: ndebuhr

deploy/templates/code.yaml

@@ -52,7 +52,6 @@ spec:
         fsGroup: 1000
       containers:
       - image: {{ .Values.code.image }}
-        imagePullPolicy: Always
         name: code
         ports:
         - name: ide
@@ -103,7 +102,6 @@ spec:
           secretName: client-ovpn
           defaultMode: 0400
       {{ end }}
-      restartPolicy: Always
 {{ if eq .Values.policies.enabled true }}
 ---
 apiVersion: networking.k8s.io/v1

deploy/templates/grafana.yaml

@@ -104,7 +104,6 @@ spec:
       containers:
       - name: seed
         image: {{ .Values.initializers.image }}
-        imagePullPolicy: Always
         command: ["/bin/bash", "-c"]
         args:
         - |

deploy/templates/guacamole.yaml

@@ -38,7 +38,6 @@ spec:
         resources: {{ toYaml .Values.guacamole.guacd.resources | nindent 10 }}
         securityContext:
           readOnlyRootFilesystem: true
-      restartPolicy: Always
 ---
 apiVersion: v1
 kind: Service
@@ -93,7 +92,6 @@ spec:
         - name: POSTGRES_PASSWORD
           value: myguac123
         resources: {{ toYaml .Values.guacamole.resources | nindent 10 }}
-      restartPolicy: Always
 ---
 apiVersion: v1
 kind: Service

deploy/templates/jupyter.yaml

@@ -62,7 +62,6 @@ spec:
           secretName: client-ovpn
           defaultMode: 0400
       {{ end }}
-      restartPolicy: Always
 {{ if eq .Values.policies.enabled true }}
 ---
 apiVersion: networking.k8s.io/v1

deploy/templates/kanboard.yaml

@@ -47,7 +47,6 @@ spec:
       - name: nginx-conf
         configMap:
           name: nginx-conf
-      restartPolicy: Always
 ---
 kind: Service
 apiVersion: v1

deploy/templates/keycloak.yaml

@@ -125,7 +125,6 @@ spec:
         image: {{ .Values.keycloak.operator.image }}
         command:
         - keycloak-operator
-        imagePullPolicy: Always
         resources: {{ toYaml .Values.keycloak.operator.resources | nindent 10 }}
         env:
           - name: WATCH_NAMESPACE

deploy/templates/landing.yaml

@@ -35,7 +35,6 @@ spec:
       - name: landing
         image: {{ .Values.landing.image }}
         resources: {{ toYaml .Values.landing.resources | nindent 10 }}
-      restartPolicy: Always
 {{ if eq .Values.policies.enabled true }}
 ---
 apiVersion: networking.k8s.io/v1

deploy/templates/oauth2-proxy.yaml

@@ -18,7 +18,6 @@ spec:
       containers:
       - name: oauth2-proxy
         image: {{ .Values.oauth2Proxy.image }}
-        imagePullPolicy: Always
         args:
         - "--session-cookie-minimal"
         - "--session-store-type=redis"

deploy/templates/pgweb.yaml

@@ -48,7 +48,6 @@ spec:
           secretName: client-ovpn
           defaultMode: 0400
       {{ end }}
-      restartPolicy: Always
 {{ if eq .Values.policies.enabled true }}
 ---
 apiVersion: networking.k8s.io/v1

deploy/templates/prometheus.yaml

@@ -40,7 +40,6 @@ spec:
       - name: prometheus-data
         persistentVolumeClaim:
           claimName: prometheus-pvc
-      restartPolicy: Always
 ---
 apiVersion: v1
 kind: ConfigMap