Skip to content

Commit c4479af

Browse files
Fix package manager installation for v1.0.8-3 (#62)
* feat: added install script and updated docs * docs: fixups to README * docs: added edit_command_buffer to README.md * fix: `fish-lsp info` logsfile location & readme wording * fix: `package.json` removed linking, reworded setup section `README.md` * fix: `package.json` pkg config * fix: audit `yarn.lock` removed deprecated `cross-spawn` * fix: removed unused fish-lsp enviornment variables w/ README changes - removed `fish_lsp_format_tabsize` & `fish_lsp_format_switch_case` - fixed `src/cli.ts` formatting for `fish-lsp info` - added `fish-lsp complete` completions for `-v/--version`, `-h/--help`, `--help-*`, when 0 subcommands and/or flags are given * docs: fixed `README.md` section order * fix: `yarn pack` and `package.json` scripts appear to be working - `yarn pack` creates a tarball of the package - `package.json` scripts are updated to properly build the tarball - added `files` field to `package.json` to include the directories necessary for the package to work *(main features working, but more testing is needed)*. See [package.json](./package.json) line 25 for more details. --- **What is this commit fixing?** when a user tries to install the fish-lsp npm package, through their package manager using something like: ```bash npm install -g fish-lsp pnpm install -g fish-lsp yarn global add fish-lsp ``` The package manager previously needs to use typescript to build the `src/**` directory, which is not necessary. This branch is testing various methods of improving the package manager installation experience. --- **TODO/Notes** - if we can get the wasm file to be included in the published package, then we can remove most of the `postinstall` related workarounds in the `package.json` scripts, which would be nice. - previous attempts at publishing the `tree-sitter-fish.wasm` file have been made. Most noteably, in versions `v1.0.0`, `v1.0.1`, etc... the `wasm` file included did not properly bundle a wasm file with a correct [magic-number](https://www.google.com/search?client=firefox-b-1-d&q=wasm+magic+number) - once the `postinstall`/`wasm` issues are resolved, building from source will no longer be necessary to install the package. * fix: conf.d not included in background analysis - removed yarn.lock - added files to package.json - removed .yarnrc.yml - successfully built on npm, yarn, & pnpm by `pack` testings - fixed minor misnumbered error code `src/diagnostics/errorCodes.ts` - removed packageManager key from package.json because of corepack * fix: rm *.wasm from .gitignore, added wasm to repo - added yarn.lock back to .gitignore * fix: added startup time w/ logger + popup support to `src/analyzer.ts` - changes made to `package.json` scripts - `dev` script for local development - `dev:watch` script for local development - `tsconfig.json` now contains a key for building `.tsbuildinfo` file and `clean` package.json removes it - `README.md` comments removed + fixes to other minor typo changes * fix: deps in package.json `typescript version too hight for eslint` - moved marked-man to `devDependencies` - typescript now using 5.5.4 in `devDependencies` * fix: ci.yml and added .npmignore * fix: added tests to ci.yml and yarn.lock * fix: fast-glob moved to dependencies * docs: minor comment to README.md * feat: fixed `src/execute-handler.ts` for testing - issue visible in [pr #61](https://github.com/ndonfris/fish-lsp/pull/61/files) Co-authored-by: branchvincent <[email protected]> * docs: fix `README.md` Client Configurations (REQUIRED) * chore: added @branchvincent to `.all-contributorsrc` Signed-off-by: nick donfris <[email protected]> * fix: `npm publish` should now work, `docs/MAN_FILE.md` updates, complete changes - `fish-lsp complete` now outputs completions for `fish-lsp env --no-global --no-local --no-comments --no-export` - `fish-lsp info --time-startup` is now a valid operation - man page was updated - updated .npmignore & .gitignore - updated README.md - added functions to `src/cli.ts` for `--time-startup` operation - added arguments to functions in `src/config.ts` for `fish-lsp env` behavior - pkg behaviour is still not working correctly * fix: removed tests from `.github/workflows/ci.yaml` because of race condition * docs: updated `docs/CHANGLOG.md`, `docs/CONTRIBUTING.md` and `README.md` * docs: updated `docs/CHANGELOG.md` & `package.json` for v1.0.8-3 --------- Signed-off-by: nick donfris <[email protected]> Co-authored-by: branchvincent <[email protected]>
1 parent c73c985 commit c4479af

29 files changed

+2023
-1462
lines changed

.all-contributorsrc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,15 @@
8383
"content",
8484
"doc"
8585
]
86+
},
87+
{
88+
"login": "branchvincent",
89+
"name": "Branch Vincent",
90+
"avatar_url": "https://avatars.githubusercontent.com/u/19800529?v=4",
91+
"profile": "https://github.com/branchvincent",
92+
"contributions": [
93+
"code"
94+
]
8695
}
8796
],
8897
"contributorsPerLine": 7,

.github/workflows/ci.yml

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,30 @@ jobs:
1616

1717
steps:
1818
- name: Checkout Code
19-
uses: actions/checkout@v3
19+
uses: actions/checkout@v4
2020

2121
- name: Install Fish Shell
2222
uses: fish-actions/[email protected]
2323

2424
- name: Set up Node.js
25-
uses: actions/setup-node@v3
25+
uses: actions/setup-node@v4
2626
with:
27-
node-version: 21.7.1
27+
node-version: 22.12.0
2828

2929
- name: Install Yarn
3030
run: npm install -g [email protected]
3131

3232
- name: Install Dependencies
3333
run: yarn install
3434

35+
- name: Build Development
36+
run: yarn dev
37+
3538
- name: Check Binary
3639
run: fish-lsp --help
3740

3841
- name: Run Lint
39-
run: yarn lint:fix
42+
run: yarn lint:fix
43+
44+
# - name: Run Test
45+
# run: yarn test

.gitignore

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ node_modules
55
*.log
66
*.tsbuildinfo
77
logs.txt
8-
*.wasm
98
wikis
9+
build
1010
test-data/staging
11-
!snippets/*.json
12-
snippets/*
11+
*.tgz
12+
*.tsbuildinfo

.npmignore

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
.git/
2+
.github/
3+
.husky/
4+
.eslintrc.cjs
5+
.eslintignore
6+
.gitignore
7+
*.tsbuildinfo
8+
.editorconfig
9+
.gitattributes
10+
*.tgz
11+
12+
yarn.lock
13+
.yarnrc.yml
14+
.yarnrc
15+
.nvmrc
16+
package-lock.json
17+
pnpm-lock.yaml
18+
npm-shrinkwrap.json
19+
20+
test-data
21+
build
22+
23+
tsconfig*.json
24+
jest.config.js
25+
commitlint.config.ts
26+
renovate.json
27+
28+
*.tsbuildinfo
29+
.editorconfig
30+
docs/*
31+
!docs/MAN_FILE.md
32+
!docs/man/fish-lsp.1

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v21.7.1
1+
v22.12.0

.yarnrc.yml

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)