Feature request: support new `{...}` syntax alternative to `begin...end`

[andradei]

fish v4.1.0 Added the new syntax to begin...end which is {...}. The lsp/formatter, however, formats {...} in a new line, which breaks the script.

Example:

Correct: this gets formatted correctly and runs as intended

false
or begin
    echo 'could be true'
end

Incorrect: the follow (correct) alternative...

false
or {
    echo 'could be true'
}

gets formatted as:

false
or
{
    echo 'could be true'
}

with { on a new line, this breaks the script with error:

Expected a command, but found end of the statement
or
  ^

[andradei]

This is an issue with fish_indent from the fish project.
I opened an issue there fish-shell/fish-shell#11984.

[andradei]

Actually, this is an issue with the LSP too. Reopening.

[ndonfris]

Yeah this would ideally be fixed in the tree-sitter-fish wasm parser. I opened an issue a while back for this here.

Once the tree-sitter language supports this feature, the {...} token support would likely require minimal changes to work correctly in the fish-lsp. The only potential issue would be with the recent hover support for concatenation tokens, e.g.,