Skip to content

BUG: Unable to disable logger handler #121

@jose-elias-alvarez

Description

@jose-elias-alvarez

Describe the bug
It doesn't seem possible to disable the logger handler using the methods described in the docs (CLI flags and environment variables).

To Reproduce

fish-lsp start --disable logger --dump
set -gx fish_lsp_disabled_handlers logger
fish-lsp start --dump

This help text refers to logging and not logger, but I see the same results when using logging as well.

Expected behavior
I expected the logger handler to be disabled, but in both of these cases it's still enabled.

Screenshots
N/A

Please complete the following information:
OS NAME: Darwin
YARN VERSION: 1.22.22
NODE VERSION: v24.10.0
FISH VERSION: fish, version 4.1.2
FISH-LSP VERSION: 1.1.0

Additional context
I took a quick look at the source, and it seems like the issue is that logger is not one of the valid handlers defined here. If that's the case and I'm not doing something wrong, I'm happy to put in a PR.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions