Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Changing download folder doesn't appear to work (again) #106

Closed
egcp opened this issue May 26, 2021 · 9 comments · Fixed by #144
Closed

[BUG] Changing download folder doesn't appear to work (again) #106

egcp opened this issue May 26, 2021 · 9 comments · Fixed by #144
Labels
bug confirmed

Comments

@egcp
Copy link

egcp commented May 26, 2021

Hi, The extension is great. However for the Gnome 40 version, the Download Folder option is not working. The user cannot choose a different folder to store the wallpapers. The option is there, and when clicked it opens a file manager to choose a different folder, but the selection is never applied. Therefore, the folder is always ~/BingWallpaper/. It worked fine for previous Gnome versions. This seems to be reported in relation to an old issue (#44). Thanks!
neffo added a commit that referenced this issue May 26, 2021
@neffo
fix directory change, relocate images #106
771e6ec
@neffo
Copy link
Owner

neffo commented May 26, 2021

Thanks for the report, I've got a fix in a branch atm. This branch still needs a bit more testing, but hoping to publish it soon.

neffo added a commit that referenced this issue Jun 1, 2021
@neffo
Version 33 - add selectable wallpapers, random mode (#102)
95ec0c5 
* multiple selectable wallpapers
* fix thumbnail loader, load select image
* add working preferences setting
* remove old images from history that are deleted
* fix getWallpaperDir
* fix timing issues breaking thumbnails
* clean ups and refactoring
* implement random
* some refactoring
* add adjustable dconf for random
* allow overrides to untested features
* check for working clipboard
* wallpaper folder menu item
* add download folder button to prefs
* fix blur prefs
* store/restore state at boot
* add next & prev buttons
* desktop notifications #50
* update build
* add link to GNOME extensions page with icon and sponsor link
* add random button to menu
* improve error & signal handling
* bump version
* shorter image names & consistent icons
* fix error on first run
* fix ES6 warnings
* fix notifications
* fix GNOME 3.28 support
* fix directory change, relocate images #106
* fix gnome 40 image moving
* improve logging
* add debug prefs
* unify strings & prefs, improve defaults
* handle prefs being opened before first refresh
@neffo
Copy link
Owner

neffo commented Jun 1, 2021

Should be fixed in #102 v33

@neffo neffo closed this as completed Jun 2, 2021
@ghost
Copy link

ghost commented Jun 2, 2021

Still not working. When i choose new folder (existing or create new one) and close settings window, when I reopen it, the download folder goes back to the state it was in before the change (even if I deleted it).

@neffo neffo reopened this Jun 3, 2021
@neffo
Copy link
Owner

neffo commented Jun 3, 2021

@ikswokor which GNOME version and distro?

when you click the open folder button where does it go?

@ghost
Copy link

ghost commented Jun 3, 2021 •
edited by ghost
Loading

this is how it looks https://youtu.be/eaY8-TEHTe0

OS - Arch Linux x86_64
kernel - 5.12.8-arch1-1
gnome version - 40.1.0
wayland - 1.19.0-1

edit// i got latest version of extension, downloaded using git

@neffo
Copy link
Owner

neffo commented Jun 3, 2021 •
edited
Loading

Yep, last minute change broke it undoing the fix. Thanks for the report (videos are great), if you are running git you can test the v34 branch for a fix.

@ghost
Copy link

ghost commented Jun 4, 2021

Yup, in branch v34 everything works great. Thanks a lot :)

@egcp
Copy link
Author

egcp commented Jun 4, 2021

Thanks! Version 34 works as expected.

@neffo neffo mentioned this issue Jun 6, 2021
Merged
8 tasks
@neffo neffo closed this as completed Jun 12, 2021
@neffo neffo reopened this Dec 20, 2021
@neffo neffo changed the title download folder not working [BUG] Changing download folder doesn't appear to work in GNOME 40 Dec 20, 2021
@neffo
Copy link
Owner

neffo commented Dec 20, 2021

Reopened as this doesn't seem to be working again

@neffo neffo mentioned this issue Dec 20, 2021
Merged
16 tasks
@neffo neffo changed the title [BUG] Changing download folder doesn't appear to work in GNOME 40 [BUG] Changing download folder doesn't appear to work (again) Dec 20, 2021
neffo added a commit that referenced this issue Dec 20, 2021
@neffo
move download folder fix #106
5887750
@neffo neffo linked a pull request Dec 20, 2021 that will close this issue
Version 38 #144
Merged
16 tasks
@neffo neffo mentioned this issue Jan 15, 2022
Closed
neffo added a commit that referenced this issue Mar 19, 2022
@neffo @JAKuhr @bagnacauda
Version 38 (#144)
fc03e48 
* Updated German, Italian and Arabic translation (#142) #14
* add gettext domain to metadata
* safer and more reliable method for _downloadImage #145
* move download folder fix #106
* set gtk4 filechooser button label #151
* better deal with home dir changes #151
* migrate from deprecated Soup.SessionAsync #150
* handle failures to get a httpsession #150
* change log error shouldn't stop prefs opening #150
* support GNOME 42, set dark style background #153 #154
* merge changes from #148
* improve user directory handling, remove '😞' char #151
* better default pref window size on gnome 40+ #147
* disable gallery, and open gallery fall back to open folder
* bump version to version 38

Co-authored-by: JAKuhr <[email protected]>
Co-authored-by: Simone Dotto <[email protected]>
Co-authored-by: Amro Soliman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 38 neffo/bing-wallpaper-gnome-extension
2 participants
@neffo @egcp