[BUG] TypeError: image is null error on newly created user accounts #246

pacho2 · 2024-09-24T08:57:57Z

Hello,

I am not sure why extension runs fine on my user account but it doesn't on newly created ones. Maybe some folder (or subfolder) is missing on the newly one, but I am unsure about which one :(

Desktop (please complete the following information):

OS: Gentoo
Extension Version: 49
GNOME Version: 45

The following errors are logged:

gnome-shell[1695]: Extension [email protected]: TypeError: image is null
                                             
                                             Stack trace:
                                               _selectImage@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:870:17
                                               _setImage@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:343:14
                                               _setConnections@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:256:14
                                               _init@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:205:14
                                               ButtonBox@resource:///org/gnome/shell/ui/panelMenu.js:13:1
                                               PanelMenuButton@resource:///org/gnome/shell/ui/panelMenu.js:99:4
                                               BingWallpaperIndicator@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:83:1
                                               enable@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:1099:34
                                               _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:253:38
                                               loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:461:32
                                               async*_loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:759:24
                                               async*_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:765:48
                                               _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:800:20
                                               async*init@resource:///org/gnome/shell/ui/extensionSystem.js:72:14
                                               _initializeUI@resource:///org/gnome/shell/ui/main.js:303:22
                                               start@resource:///org/gnome/shell/ui/main.js:176:11
                                               @resource:///org/gnome/shell/ui/init.js:12:47
                                               @resource:///org/gnome/shell/ui/init.js:21:20

Thanks for your help

The text was updated successfully, but these errors were encountered:

neffo · 2024-09-24T10:13:36Z

This is the default, can you if your Pictures or Desktop folders are writable?

let userPicturesDir = GLib.get_user_special_dir(GLib.UserDirectory.DIRECTORY_PICTURES);
let userDesktopDir = GLib.get_user_special_dir(GLib.UserDirectory.DIRECTORY_DESKTOP);
BingWallpaperDir = (userPicturesDir?userPicturesDir:userDesktopDir) + '/BingWallpaper/';

It's possible your Distro has read-only for one of those?

neffo · 2024-09-24T11:45:23Z

Are you able to test the version 50 branch?

I've added error notifications:

pacho2 · 2024-09-30T15:22:44Z

Sadly the notification is not shown because extension fails to start at login with:

Extension [email protected]: TypeError: image is null
                                              
                                              Stack trace:
                                                _selectImage@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:930:17
                                                _setImage@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:382:14
                                                _setConnections@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:267:14
                                                _init@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:211:14
                                                ButtonBox@resource:///org/gnome/shell/ui/panelMenu.js:13:1
                                                PanelMenuButton@resource:///org/gnome/shell/ui/panelMenu.js:99:4
                                                BingWallpaperIndicator@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:89:1
                                                enable@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:1164:34
                                                _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:253:38
                                                loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:461:32
                                                async*_loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:759:24
                                                async*_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:765:48
                                                _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:800:20
                                                async*init@resource:///org/gnome/shell/ui/extensionSystem.js:72:14
                                                _initializeUI@resource:///org/gnome/shell/ui/main.js:303:22
                                                start@resource:///org/gnome/shell/ui/main.js:176:11
                                                @resource:///org/gnome/shell/ui/init.js:12:47
                                                @resource:///org/gnome/shell/ui/init.js:21:20

I have full permissions on my ~/Pictures/ directory, but I don't know why it fails to create the subdir :/

pacho2 · 2024-09-30T15:27:49Z

But even creating manually the dir, it keeps failing in the same way. I have tried to enable debug from the extension settings, but it is the same error:

Extension [email protected]: TypeError: image is null
                                              
                                              Stack trace:
                                                _selectImage@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:930:17
                                                _setImage@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:382:14
                                                _setConnections@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:267:14
                                                _init@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:211:14
                                                ButtonBox@resource:///org/gnome/shell/ui/panelMenu.js:13:1
                                                PanelMenuButton@resource:///org/gnome/shell/ui/panelMenu.js:99:4
                                                BingWallpaperIndicator@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:89:1
                                                enable@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:1164:34
                                                _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:253:38
                                                loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:461:32
                                                async*_loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:759:24
                                                async*_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:765:48
                                                _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:800:20
                                                async*init@resource:///org/gnome/shell/ui/extensionSystem.js:72:14
                                                _initializeUI@resource:///org/gnome/shell/ui/main.js:303:22
                                                start@resource:///org/gnome/shell/ui/main.js:176:11
                                                @resource:///org/gnome/shell/ui/init.js:12:47
                                                @resource:///org/gnome/shell/ui/init.js:21:20

pacho2 · 2024-09-30T15:34:15Z

Maybe it is failing to download the image? But I cannot see anywhere in the logs where it is trying to fetch it from, and nothing is downloaded to the BingWallpaper folder

neffo · 2024-09-30T15:42:01Z

This triggering an error in startup possibly. I don't understand how it's triggering an error there but can you comment out the log function call on row 930 in extension.js?

log('_selectImage: ' + this.selected_image + ' = ' + (image && image.urlbase) ? image.urlbase : 'not found');

pacho2 · 2024-10-01T07:39:11Z

Nice, now it can start and the failure is:

 JS ERROR: TypeError: time.to_unix is not a function
                                              friendly_time_diff@file:///usr/share/gnome-shell/extensions/[email protected]/utils.js:396:24
                                              _openMenu@file:///usr/share/gnome-shell/extensions/[email protected]/extension.js:367:30
                                              @resource:///org/gnome/shell/ui/init.js:21:20
Oct 01 09:34:07 gec-pacho gjs[91944]: g_task_return_error: assertion '!task->ever_returned' failed

martywesley · 2024-10-14T16:27:27Z

I was getting the same "TypeError: image is null" error on my account. I commented out the log call on line 930 as you suggested and it started working for me. So not entirely the same problem as OP reported, but there's clearly a problem with that log line.

JordanViknar · 2024-10-22T06:46:47Z

I can also confirm I've encountered the same error, and the same fix has worked successfully.
However, my user account isn't new, so I'm not convinced this is related to that.

hmenke · 2025-01-08T08:32:38Z

There is a missing set of parentheses in the log statement. The argument

'_selectImage: ' + this.selected_image + ' = ' + (image && image.urlbase) ? image.urlbase : 'not found'

is actually equivalent to

('_selectImage: ' + this.selected_image + ' = ' + (image && image.urlbase)) ? image.urlbase : 'not found'

and since this conditional will always evaluate to a non-empty string (which is “truthy”) it will always try to dereference image.urlbase even if image is null. The ternary operator has really low precedence so it will always try to evaluate everything that's to the left of the ? first.

The correct statement would be

--- a/extension.js
+++ b/extension.js
@@ -927,7 +927,7 @@ class BingWallpaperIndicator extends Button {
 
                 if (image)
                     this.imageIndex = Utils.imageIndex(imageList, image.urlbase);
-                log('_selectImage: ' + this.selected_image + ' = ' + (image && image.urlbase) ? image.urlbase : 'not found');
+                log('_selectImage: ' + this.selected_image + ' = ' + (image && image.urlbase ? image.urlbase : 'not found'));
             }
         }

pacho2 added the bug label Sep 24, 2024

remiceres mentioned this issue Dec 9, 2024

Getting Error in gnome shell extensions page after installing. #251

Open

hmenke linked a pull request Jan 8, 2025 that will close this issue

fix operator precedence confusion in log statement #258

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] TypeError: image is null error on newly created user accounts #246

[BUG] TypeError: image is null error on newly created user accounts #246

pacho2 commented Sep 24, 2024

neffo commented Sep 24, 2024 •

edited

Loading

neffo commented Sep 24, 2024

pacho2 commented Sep 30, 2024

pacho2 commented Sep 30, 2024

pacho2 commented Sep 30, 2024

neffo commented Sep 30, 2024 •

edited

Loading

pacho2 commented Oct 1, 2024

martywesley commented Oct 14, 2024

JordanViknar commented Oct 22, 2024

hmenke commented Jan 8, 2025

[BUG] TypeError: image is null error on newly created user accounts #246

[BUG] TypeError: image is null error on newly created user accounts #246

Comments

pacho2 commented Sep 24, 2024

neffo commented Sep 24, 2024 • edited Loading

neffo commented Sep 24, 2024

pacho2 commented Sep 30, 2024

pacho2 commented Sep 30, 2024

pacho2 commented Sep 30, 2024

neffo commented Sep 30, 2024 • edited Loading

pacho2 commented Oct 1, 2024

martywesley commented Oct 14, 2024

JordanViknar commented Oct 22, 2024

hmenke commented Jan 8, 2025

neffo commented Sep 24, 2024 •

edited

Loading

neffo commented Sep 30, 2024 •

edited

Loading