[Feature Request] Support java.cleanup.actions

[sainnhe]

At present, the setting java.cleanup.actionsOnSave is supported, which can run a set of cleanup actions on document save.

The upstream now supports java.cleanup.actions, which is triggered manually.

IMO cleanup actions is very necessary but in many cases should not be triggered on save, since some files are very low-level and should not be easily modified.

So vscode-java added a new setting that supported manually trigger cleanup acions: redhat-developer/vscode-java#3424

Is it possible to allow manually triggering in coc-java?

[asmodeus812]

@sainnhe try this 7741efb Let me know if it works for you, i did a few small tests, its added as a code command, not code action fyi.

[sainnhe]

@asmodeus812 Sorry for late reply. I'm too busy recently :(

I cannot find this commit in your fork, is the branch deleted?

I've looked into your code, there seems to be 2 problems:

1. The command is not registered in package.json
2. There is a configuration in vscode-java named java.cleanup.actions which has the following definition:

        "java.cleanup.actions": {
          "type": "array",
          "markdownDescription": "The list of clean ups to be run on the current document when it's saved or when the cleanup command is issued. Clean ups can automatically fix code style or programming mistakes. Click [HERE](command:_java.learnMoreAboutCleanUps) to learn more about what each clean up does.",
          "items": {
            "type": "string",
            "enum": [
              "qualifyMembers",
              "qualifyStaticMembers",
              "addOverride",
              "addDeprecated",
              "stringConcatToTextBlock",
              "invertEquals",
              "addFinalModifier",
              "instanceofPatternMatch",
              "lambdaExpressionFromAnonymousClass",
              "lambdaExpression",
              "switchExpression",
              "tryWithResource",
              "renameFileToType"
            ]
          },
          "default": [
            "renameFileToType"
          ],
          "scope": "window",
          "order": 10
        },

This setting can control what actions to be executed when doCleanup command is executed. Maybe it can also be added.

[sainnhe]

I implemented the doCleanup command and java.cleanup.actions setting based on your commit and the source code of vscode-java sainnhe@e838824

It works nicely on my machine. Would you mind merge my commit into your branch and open a PR?

[asmodeus812]

@sainnhe i think my changes were recently up streamed, the doCleanup should work now, just make sure to build this from master and test it let me know if we can close this issue.

[chemzqm]

make sure to build this from master and test it let me know if we can close this issue.

Or use coc-java@1.26.0

[asmodeus812]

@chemzqm by the way the workflow and script i had added in my fork had the version pinned at 1.43 because of the required java version, which was 22 i think for any version of and including 1.44+ of JDTLS, however recently the @sainnhe was merged after my up streamed changed, his changes to the server files however i believe were version 1.39, while my fork had the jdtls server files on version 1.43, keep in mind that there are a few incompatible changes, like the signature-change action api was changed a bit. In the workflow file i have commented out the line that pulls the version dynamically, that can be uncommented and the workflow will run every month pulling the newest server + lombok.

[chemzqm]

coc-java@1.26.0 uses jdtls 1.45.0 and lombok 1.18.36.

The CI should work now.