Runs When it Shouldn't

[jherdman]

Given some project that DOES NOT use Prettier, coc-prettier, when using the following configuration, will run on save:

{
  "coc.preferences.formatOnSaveFiletypes": ["css", "markdown"]
}

This is actually as documented! I propose that prettier.requireConfig should default to true. I believe that this is the expected behaviour of this plugin.

[jherdman]

Another thing I should note is that prettier.requireConfig doesn't seem to work. Even when a configuration file is absent formatting runs.

[chemzqm]

It doesn't work when you have global prettier config file.

[jherdman]

I don't have a global config

…

On Thu, Sep 10, 2020, 12:06 Qiming zhao ***@***.***> wrote: It doesn't work when you have global prettier config file. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#87 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAZZHLQKFI7K4NDQ3AA5TSFD2P3ANCNFSM4QHWX6UA> .

[chemzqm]

Could be prettier config file in one of the parent folders.

[jherdman]

Could be prettier config file in one of the parent folders.

Is this behaviour part of Prettier or this plugin?

[chemzqm]

It's resolved by prettier

[atomdmac]

(Apologies for the necromancy): I'm running into this as well. Running the following results in no output:

prettier --find-config-path ./

However, if I add a .prettierrc to my project directory, the same command yields this output:

.prettierrc

This indicates to me that the issue is not that a global config is being used. Is there something else I can check?

[brandonpittman]

I'm sure it's because you have an .editorconfig file in the root. That's what I just got bit by. Deleted that file from the root and the unwanted formats stopped.

[brandonpittman]

This plugin could really use an option to disable using .editorconfig.

[jherdman]

That is definitely what it is for me. I glossed right over that in the docs.

[atomdmac]

Can confirm that it was my issue as well.