Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifical url checked too early #36

Open
Ecdcaeb opened this issue Oct 26, 2024 · 3 comments
Open

Artifical url checked too early #36

Ecdcaeb opened this issue Oct 26, 2024 · 3 comments

Comments

@Ecdcaeb
Copy link

Ecdcaeb commented Oct 26, 2024

I noticed here https://github.com/neoforged/LegacyInstaller/blob/main/src/main/java/net/minecraftforge/installer/DownloadUtils.java#L66 . For libraries that are definitely obtained locally (Downloaded file locally from) , we used to leave the url blank (https://github.com/neoforged/NeoForge/blob/1.16.x/build.gradle#L156). Do not include the URL so that the installer/launcher won't grab it . But now it is examined here first. In this case, the installation of the local maven\ library will fail. One possible solution is to make the url not empty, for example by padding it with a space. But I think this problem can be solved better.

A library without a URL is not invalid, it can still be downloaded locally from localPath. This is a known supported feature.

@shartte
Copy link
Contributor

shartte commented Oct 26, 2024

You are not actually explaining what the symptom of this is other than the message.

@Ecdcaeb
Copy link
Author

Ecdcaeb commented Oct 26, 2024

You are not actually explaining what the symptom of this is other than the message.

Thanks for the correction, I updated the description.

@shartte
Copy link
Contributor

shartte commented Oct 26, 2024

I am sorry, I don't follow your bug report. What about installing NeoForge is broken with this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants