We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url
I noticed here https://github.com/neoforged/LegacyInstaller/blob/main/src/main/java/net/minecraftforge/installer/DownloadUtils.java#L66 . For libraries that are definitely obtained locally (Downloaded file locally from) , we used to leave the url blank (https://github.com/neoforged/NeoForge/blob/1.16.x/build.gradle#L156). Do not include the URL so that the installer/launcher won't grab it . But now it is examined here first. In this case, the installation of the local maven\ library will fail. One possible solution is to make the url not empty, for example by padding it with a space. But I think this problem can be solved better.
Downloaded file locally from
Do not include the URL so that the installer/launcher won't grab it
maven\
A library without a URL is not invalid, it can still be downloaded locally from localPath. This is a known supported feature.
localPath
The text was updated successfully, but these errors were encountered:
You are not actually explaining what the symptom of this is other than the message.
Sorry, something went wrong.
Thanks for the correction, I updated the description.
I am sorry, I don't follow your bug report. What about installing NeoForge is broken with this code?
No branches or pull requests
I noticed here https://github.com/neoforged/LegacyInstaller/blob/main/src/main/java/net/minecraftforge/installer/DownloadUtils.java#L66 . For libraries that are definitely obtained locally (
Downloaded file locally from
) , we used to leave the url blank (https://github.com/neoforged/NeoForge/blob/1.16.x/build.gradle#L156).Do not include the URL so that the installer/launcher won't grab it
. But now it is examined here first. In this case, the installation of the localmaven\
library will fail. One possible solution is to make the url not empty, for example by padding it with a space. But I think this problem can be solved better.A library without a URL is not invalid, it can still be downloaded locally from
localPath
. This is a known supported feature.The text was updated successfully, but these errors were encountered: