Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] TagsUpdatedEvent does not fire on clients after connecting to a dedicated server #1694

Open
Fuzss opened this issue Nov 19, 2024 · 0 comments
Labels
triage Needs triaging and confirmation

Comments

@Fuzss
Copy link

Fuzss commented Nov 19, 2024

Minecraft Version: 1.21.3

NeoForge Version: 21.3.34

There is simply a patch missing for firing the event in ClientConfigurationPacketListenerImpl.

Fabric patches their callback in at the lambda passed to ClientConfigurationPacketListenerImpl::runWithResources in ClientConfigurationPacketListenerImpl::handleConfigurationFinished just after RegistryDataCollector::collectGameRegistries is called.

Currently the event only fires in ClientPacketListener::handleUpdateTags on the client-side, which only seems to handle data reloads, but not the initial load when joining.

@Fuzss Fuzss added the triage Needs triaging and confirmation label Nov 19, 2024
@Fuzss Fuzss changed the title [1.21.3] TagsUpdatedEvent does not fire on a client after connecting to a server [1.21.3] TagsUpdatedEvent does not fire on clients after connecting to a dedicated server Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Needs triaging and confirmation
Projects
None yet
Development

No branches or pull requests

1 participant