Skip to content

Commit cd75bfb

Browse files
committed
TASK: Drop runBare() override from StandaloneViewTest
As of PHPUnit 11 `runBare()` is a `final` method. This was written ages ago by Sebastian Kurfürst, who recently said: > IMHO we wanted to run each test twice to run it without cache and > then with cache. But it seems this was broken anyways since a long > time – so we can drop it
1 parent 19ac0ef commit cd75bfb

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

Neos.FluidAdaptor/Tests/Functional/View/StandaloneViewTest.php

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -30,21 +30,6 @@ class StandaloneViewTest extends FunctionalTestCase
3030
*/
3131
protected $standaloneViewNonce = '42';
3232

33-
/**
34-
* Every testcase should run *twice*. First, it is run in *uncached* way, second,
35-
* it is run *cached*. To make sure that the first run is always uncached, the
36-
* $standaloneViewNonce is initialized to some random value which is used inside
37-
* an overridden version of StandaloneView::createIdentifierForFile.
38-
*/
39-
public function runBare(): void
40-
{
41-
$this->standaloneViewNonce = uniqid('', true);
42-
parent::runBare();
43-
$numberOfAssertions = $this->getNumAssertions();
44-
parent::runBare();
45-
$this->addToAssertionCount($numberOfAssertions);
46-
}
47-
4833
/**
4934
* @test
5035
*/

0 commit comments

Comments
 (0)