Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!!! Remove obsolete Neos service routes with Neos 9.0 #5423

Open
mhsdesign opened this issue Jan 7, 2025 · 1 comment
Open

!!! Remove obsolete Neos service routes with Neos 9.0 #5423

mhsdesign opened this issue Jan 7, 2025 · 1 comment
Labels

Comments

@mhsdesign
Copy link
Member

mhsdesign commented Jan 7, 2025

Following are obsolete as they are not required by the Neos Ui anymore.

RESTful WorkspacesController routes

The workspace routes will not work with persistent object identifiers and flow routing framework anymore as they are now pure dbal content repository core objects and some metadata is even managed by neos externally. A api would need to be fully rewritten.

Removed via #5118

Original controller class Neos\Neos\Controller\Module\Management\WorkspacesController - now partially part of the Neos.Workspace.Ui package but not API.

Previously available routes in 8.3

GET    neos/service/workspaces
GET    neos/service/workspaces/{workspace}
POST   neos/service/workspaces/{baseWorkspace}/{workspaceName}
PUT    neos/service/workspaces/{workspace}

Legacy WorkspaceController routes

Removed via 0baacaa

Obsolete controller class Neos\Neos\Service\Controller\WorkspaceController

Previously available routes in 8.3

GET    neos/service/workspaces-rpc/get-workspace-wide-unpublished-nodes
PUT    neos/service/workspaces-rpc/publish-node
PUT    neos/service/workspaces-rpc/publish-nodes
PUT    neos/service/workspaces-rpc/discard-node
PUT    neos/service/workspaces-rpc/discard-nodes
PUT    neos/service/workspaces-rpc/publish-all
PUT    neos/service/workspaces-rpc/discard-all

Legacy NodeController routes

Removed via 0baacaa

Obsolete controller class Neos\Neos\Service\Controller\NodeController

It was documented as legacy and probably unused in Neos 8.3 with the new Ui already:

This controller should be, step-by-step, transformed into a clean REST controller (see NEOS-190 and NEOS-199).
Since this is a rather big endeavor, we slice the elephant and move methods in a clean way from here to the
new NodesController (\Neos\Neos\Controller\Service\NodesController)

Previously available routes in 8.3

GET    neos/service/node/get-child-nodes-for-tree
GET    neos/service/node/filter-child-nodes-for-tree
GET    neos/service/node/search-page
POST   neos/service/node/create
POST   neos/service/node/create-and-render
POST   neos/service/node/create-node-for-the-tree
PUT    neos/service/node/discard-node
PUT    neos/service/node/move
PUT    neos/service/node/move-and-render
PUT    neos/service/node/copy
PUT    neos/service/node/copy-and-render
PUT    neos/service/node/update
PUT    neos/service/node/update-and-render
POST   neos/service/node/delete
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this issue Jan 7, 2025
…troller`

This legacy service controller was removed see
neos#5423

But as identified here there is still a method privilege to be adjusted:
neos#4478 (comment)
@mhsdesign
Copy link
Member Author

mhsdesign commented Jan 7, 2025

This issue ist mostly for documentation - the changes have already been done. Does anyone have hard feelings for those dead apis? :D

cc @kitsunet @markusguenther

i suppose it was all ember stuff and sometimes things for the "perfect" world for that neos would be controllable fully by rest.

If not ill close this.

@mhsdesign mhsdesign added the 9.0 label Jan 7, 2025
mhsdesign added a commit to mhsdesign/neos-development-collection that referenced this issue Jan 13, 2025
…troller`

This legacy service controller was removed see
neos#5423

But as identified here there is still a method privilege to be adjusted:
neos#4478 (comment)
neos-bot pushed a commit to neos/neos that referenced this issue Jan 14, 2025
…troller`

This legacy service controller was removed see
neos/neos-development-collection#5423

But as identified here there is still a method privilege to be adjusted:
neos/neos-development-collection#4478 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant