BUGFIX: Prevent premature connection to database in WorkspaceMetadataAndRoleRepository

[mhsdesign]

Im currently experimenting with a faster node controller which takes the resolved node address (which is cached via flows routing cache) and then looks up the cache entry for the document and outputs that. (For the component engine ^^)

Now because we nowadays prever eager injections via constructor or typed property a database connection is created already only because the NodeController injects the ContentRepositoryAuthorizationService eagerly even it is not asked a question.

This pr ensures the repository fetches the connection only on use. Alternatively we can move the lazy injection to the node controller by using:

/**
 * @var ContentRepositoryAuthorizationService
 * @Flow\Inject
 */
protected $contentRepositoryAuthorizationService;

Upgrade instructions

Review instructions

Checklist

• Code follows the PSR-2 coding style
• Tests have been created, run and adjusted as needed
• The PR is created against the lowest maintained branch
• Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
• Reviewer - The first section explains the change briefly for change-logs
• Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

[kdambekalns]

I think it is quite fair to assume the repository will need a database connection. I'd rather inject the repository itself lazily wherever I am not sure I'll need it.