Appears to select the secondary monitor, not primary monitor

[wavebeem]

I have a 1920x1080 @ 360 Hz primary monitor in landscape orientation and a 1920x1080 @ 60 Hz secondary monitor in portrait orientation. It looks like the code is assuming monitor 0 is the primary monitor. I have no idea why monitor 0 is my secondary monitor, as my primary is numbered 1 in Windows settings and secondary is numbered 2. My secondary monitor is on the left, which could maybe be part of the problem?

---

Nice work on this btw! I searched winget and was happy to see a fetch tool in there already.

[nepnep39]

The windows api struct that I used to get resolution has pretty vague documentation and I wasn't able to reproduce this on my machine

according to microsoft: https://learn.microsoft.com/en-us/windows/win32/api/wingdi/ns-wingdi-devmodew

For displays, specifies the width, in pixels, of the visible device surface.

Surprisingly I couldn't find any info on what it considers to be the visible device surface. I tried rearranging my monitors backwards like you have and rerunning winsat formal but it still chose to use the resolution of the display numbered as one. I might rewrite this function in the next release because it has had problems in the past that by design can't really be fixed (for example using any DPI scaling other than 100% will return an incorrect resolution) ((actually I fixed this lol))

[wavebeem]

Yeah the documentation was pretty slim. I got lucky with some searches and I think I figured it out. I verified this chooses the primary monitor correctly when I switched primary monitors in the Windows 11 settings.

I installed Microsoft Visual Studio Community 2022 (64-bit), but I had problems with the #include <localfile> syntax and had to convert those to #include "localfile" for the code to compile. After I did that, I was able to update the getresolution function to use a while loop and check the StateFlags for DISPLAY_DEVICE_PRIMARY_DEVICE

I don't really have a good sense for C++ style or what you'd want out of external contributions on this, so for now I'm just going to send you the updated function and see what you think:

void getresolution(int& horizontal, int& vertical, int& hz)
{
	DISPLAY_DEVICE dd{};
	dd.cb = sizeof(dd);
	
	auto displayIndex = 0;
	while (EnumDisplayDevices(NULL, displayIndex, &dd, 0)) {
		if (dd.StateFlags & DISPLAY_DEVICE_PRIMARY_DEVICE) {
			DEVMODE dm{};
			EnumDisplaySettings(dd.DeviceName, ENUM_CURRENT_SETTINGS, &dm);
			dm.dmSize = sizeof(dm);
			dm.dmDriverExtra = 0;
			horizontal = dm.dmPelsWidth;
			vertical = dm.dmPelsHeight;
			hz = dm.dmDisplayFrequency;
			break;
		}
		displayIndex++;
	}
}

[nepnep39]

thanks, ill mess with this a bit and hopefully get something working

[wavebeem]

Happy to help!