Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulator/Physics: Add test cases for DistanceSensor #22

Open
josefbehr opened this issue Jul 25, 2013 · 3 comments
Open

Simulator/Physics: Add test cases for DistanceSensor #22

josefbehr opened this issue Jul 25, 2013 · 3 comments

Comments

@josefbehr
Copy link
Contributor

DistanceSensor seems to be not working correctly (small errors between visualisation and measured values?), should be tested automatically, since the sensor will probably be used in experiments!

@ghost ghost assigned josefbehr Jul 25, 2013
@josefbehr
Copy link
Contributor Author

Why does the DistanceSensor not provide its own box for representation in simulation and collision calculation? Should this be added to remove scripting overhead (as is done in the LightSensor)?
@cybott any comments regarding this?

@josefbehr
Copy link
Contributor Author

TODO:

  • remove DeadZone and Range parameters, replace with RayLength and automatic exclusion of parent objects from collision calculations
  • code refactoring
  • automatically add a box geometry representing the sensor object
  • finish test cases for DistanceRay, write some for the sensor itself

@josefbehr
Copy link
Contributor Author

Although the refactoring went great and the code as well as the scripting setup for the sensor are much cleaner now, I can for the hell of it not figure out, why, in the changed version(s), the collision rule returns no collision points.

@cybott maybe you have a little time to throw a look? to me all seems perfectly ok, but no collisions are reported.

Current working version: https://github.com/nerd-toolkit/nerd/blob/master/nerd/simulator/simulator/Physics/DistanceSensor.cpp
Refactored version using new SensorBox base class: https://gist.github.com/josefbehr/4755105aca2c86fbfdf1
A version without using DistanceRay, but collision objects and geometries directly shows the same problem.

If no solution is found in the next few days, I'll revert to the current git version and just try to clean it up a bit (in addition to tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant