Skip to content

Commit e1e2d78

Browse files
authored
Add more info to failed device_type creations (#81)
1 parent 542a56a commit e1e2d78

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

netbox_api.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ def create_device_types(self, device_types_to_add):
8989
self.handle.verbose_log(f'Device Type Created: {dt.manufacturer.name} - '
9090
+ f'{dt.model} - {dt.id}')
9191
except pynetbox.RequestError as e:
92-
self.handle.log(e.error)
92+
self.handle.log(f'Error {e.error} creating device type:'
93+
f' {device_type["manufacturer"]["name"]} {device_type["model"]}')
94+
continue
9395

9496
if "interfaces" in device_type:
9597
self.device_types.create_interfaces(device_type["interfaces"], dt.id)

repo.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def get_devices(self, base_path, vendors: list = None):
7575
vendor_dirs = os.listdir(base_path)
7676

7777
for folder in [vendor for vendor in vendor_dirs if not vendors or vendor.casefold() in vendors]:
78-
if folder.casefold() is not "testing":
78+
if folder.casefold() != "testing":
7979
discovered_vendors.append({'name': folder,
8080
'slug': self.slug_format(folder)})
8181
for extension in self.yaml_extensions:

0 commit comments

Comments
 (0)