Add Topology Button To Individual Region Pages #493 #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for your contribution!
I'm afraid it doesn't. You've created a template but you have omitted to create a class for the template content. |
dreng
requested changes
May 16, 2024
netbox_topology_views/templates/netbox_topology_views/region_button.html
Show resolved
Hide resolved
|
@dreng thanks. Change made and pushed . Please review |
You added a newline, which is good. You did not notice my first comment, right? You need to add a class for the template content. Otherwise the button will not be shown. |
|
@dreng looks like I want to make some improvements to it and the product such as different colors for the group boundaries. So I’ll close the request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #493
This will add a Topology Button to the Region Page