Skip to content

Allow disabling of 'Topology' button #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodvand opened this issue May 12, 2025 · 5 comments
Open

Allow disabling of 'Topology' button #633

rodvand opened this issue May 12, 2025 · 5 comments
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Request for new feature or change to existing feature

Comments

@rodvand
Copy link

rodvand commented May 12, 2025

NetBox version

v4.3.0

Topology Views version

v4.2.1

Feature type

New functionality

Proposed functionality

I would like to disable the standard Topology button present on the various views.

Use case

I want to add various parameters to the link, so I just make a Custom Link containing the various options wanted. In this case we are stuck with two Topology-buttons, and this confuses users.

External dependencies

No external dependencies, should only require an option in the plugin config to disable the button functionality.

@rodvand rodvand added the type: feature Request for new feature or change to existing feature label May 12, 2025
@mhdask
Copy link

mhdask commented May 28, 2025

I agree with this, we are also using custom links to provide additional parameters

@mattieserver
Copy link
Collaborator

This is related to #627, i will create a release so the changes are in the PIP version

@dreng
Copy link
Collaborator

dreng commented Jun 2, 2025

This not really related to #627, because the TO likes to remove the button completely.

The main question here is: Do we need the default button at all? Since we needed to hard code the options for the output in the modal window, it is not very versatile anyway. Custom links are much more powerful. I tend to completely get rid of the code.

@dreng dreng reopened this Jun 2, 2025
@mhdask
Copy link

mhdask commented Jun 2, 2025

The main question here is: Do we need the default button at all? Since we needed to hard code the options for the output in the modal window, it is not very versatile anyway. Custom links are much more powerful. I tend to completely get rid of the code.

I am unsure what the button even does, will it show the full topology or only the modal from which you clicked the button?
I dont think it is intuitive what the button actually does

@dreng
Copy link
Collaborator

dreng commented Jun 2, 2025

I've never found the feature useful for my personal needs. That said, I found it quite intuitive. The topology is shown from the Object's perspective. If you click the button on a site page, you will get the whole topology for the site. Same with locations.

The original feature has been requested in #191 a couple of years ago. I'd like to hear the opinion of @renatoalmeidaoliveira and @mattieserver. Do you think that the topology button is still necessary since custom links can replace it? I've never felt comfortable with the modal window anyway, how about you?

@dreng dreng added the status: under review Further discussion is needed to determine this issue's scope and/or implementation label Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: under review Further discussion is needed to determine this issue's scope and/or implementation type: feature Request for new feature or change to existing feature
Projects
None yet
Development

No branches or pull requests

4 participants