-
Notifications
You must be signed in to change notification settings - Fork 81
Allow disabling of 'Topology' button #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I agree with this, we are also using custom links to provide additional parameters |
This is related to #627, i will create a release so the changes are in the PIP version |
This not really related to #627, because the TO likes to remove the button completely. The main question here is: Do we need the default button at all? Since we needed to hard code the options for the output in the modal window, it is not very versatile anyway. Custom links are much more powerful. I tend to completely get rid of the code. |
I am unsure what the button even does, will it show the full topology or only the modal from which you clicked the button? |
I've never found the feature useful for my personal needs. That said, I found it quite intuitive. The topology is shown from the Object's perspective. If you click the button on a site page, you will get the whole topology for the site. Same with locations. The original feature has been requested in #191 a couple of years ago. I'd like to hear the opinion of @renatoalmeidaoliveira and @mattieserver. Do you think that the topology button is still necessary since custom links can replace it? I've never felt comfortable with the modal window anyway, how about you? |
NetBox version
v4.3.0
Topology Views version
v4.2.1
Feature type
New functionality
Proposed functionality
I would like to disable the standard Topology button present on the various views.
Use case
I want to add various parameters to the link, so I just make a Custom Link containing the various options wanted. In this case we are stuck with two Topology-buttons, and this confuses users.
External dependencies
No external dependencies, should only require an option in the plugin config to disable the button functionality.
The text was updated successfully, but these errors were encountered: