Skip to content

Commit 0cfa8d2

Browse files
authored
ci: use windows-2025 image (#7344)
* ci: use windows-2025 image * ci: update windows runner in integration tests * ci: update windows runner in unit tests
1 parent 18ba162 commit 0cfa8d2

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

.github/workflows/e2e-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
timeout-minutes: 20
2020
strategy:
2121
matrix:
22-
os: [windows-latest]
22+
os: [windows-2025]
2323
# Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884
2424
node-version: ['20.12.2', '22']
2525
fail-fast: false

.github/workflows/integration-tests.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@ jobs:
1717
timeout-minutes: 40
1818
strategy:
1919
matrix:
20-
os: [ubuntu-latest, macOS-latest, windows-latest]
20+
os: [ubuntu-latest, macOS-latest, windows-2025]
2121
# Pinning 20.x version as a temporary workaround due to this https://github.com/nodejs/node/issues/52884
2222
node-version: ['20.12.2', '22']
2323
shard: ['1/4', '2/4', '3/4', '4/4']
2424

2525
exclude:
26-
- os: windows-latest
26+
- os: windows-2025
2727
node-version: '22'
2828
fail-fast: false
2929
steps:
@@ -32,7 +32,7 @@ jobs:
3232
run: |
3333
netsh int ipv4 set dynamicport tcp start=1025 num=64511
3434
REG ADD HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\TCPIP\Parameters /v TcpTimedWaitDelay /t REG_DWORD /d 30 /f
35-
if: "${{ matrix.os == 'windows-latest' }}"
35+
if: "${{ matrix.os == 'windows-2025' }}"
3636

3737
- name: Git checkout
3838
uses: actions/checkout@v4
@@ -113,7 +113,7 @@ jobs:
113113
# Can be replaced with larger node 23 tests in the future.
114114
integration-win-node-23:
115115
name: Integration test windows latest node23 specific
116-
runs-on: windows-latest
116+
runs-on: windows-2025
117117
timeout-minutes: 40
118118
steps:
119119
# This improves Windows network performance, we need this since we open many ports in our tests
@@ -172,7 +172,7 @@ jobs:
172172
id: test-coverage-flags
173173
# For windows we have to use $env:
174174
run: |-
175-
os=windows-latest
175+
os=windows-2025
176176
node=$(node --version)
177177
echo "os=${os/-latest/}" >> $GITHUB_OUTPUT
178178
echo "os=${os/-latest/}" >> $env:GITHUB_OUTPUT
@@ -184,7 +184,7 @@ jobs:
184184
uses: actions/upload-artifact@v4
185185
if: always()
186186
with:
187-
name: npm-logs--windows-latest--23x
187+
name: npm-logs--windows-2025--23x
188188
path: |
189189
~/.npm/_logs/**/*
190190

.github/workflows/unit-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,10 @@ jobs:
1616
runs-on: ${{ matrix.os }}
1717
strategy:
1818
matrix:
19-
os: [ubuntu-latest, macOS-latest, windows-latest]
19+
os: [ubuntu-latest, macOS-latest, windows-2025]
2020
node-version: ['20.12.2', '22.x']
2121
exclude:
22-
- os: windows-latest
22+
- os: windows-2025
2323
node-version: '22.x'
2424
fail-fast: false
2525
steps:

0 commit comments

Comments
 (0)