comments on yang package

[lllyfeng]

in https://github.com/netmod-wg/yang-ver-dt/blob/master/yang-packages/draft-ietf-netmod-yang-packages.txt#L2541

1. I don't see any definition for ietf-yang-package-defn-pkg.
2. I think pkg-schema should be used to indicate the data of modules included pkg-schema should be presented in content-data. but I see the content-data is the data of module "ietf-yang-package-instance", so the content-schema should be module "ietf-yang-package-instance"?
   suggestion:
   OLD:
   {
   "ietf-yang-instance-data:instance-data-set": {
   "name": "example-ietf-network-device-pkg",
   "content-schema": {
   "pkg-schema": {
   "name": "ietf-yang-package-defn-pkg",
   "version": "0.1.0"
   }
   },
   ...
   }
   NEW:
   {
   "ietf-yang-instance-data:instance-data-set": {
   "name": "example-ietf-network-device-pkg",
   "content-schema": {
   "module": [
   "ietf-yang-package-instance@2020-01-21"
   ]
   },
3. some examples use different module name for content-data, please see L2555, the module name is "ietf-yang-package-instance", but in L2887, the module name is "ietf-yang-package",L2936 is the same with L2887

file "example-ietf-network-device-pkg.json"
========= NOTE: '' line wrapping per BCP XX (RFC XXXX) ===========

{
"ietf-yang-instance-data:instance-data-set": {
"name": "example-ietf-network-device-pkg",
"content-schema": {
"pkg-schema": {
"name": "ietf-yang-package-defn-pkg",
"version": "0.1.0"
}
},
"description": "YANG package definition",
"content-data": {
"ietf-yang-package-instance:yang-package": {
"name": "example-ietf-network-device-pkg",
"version": "1.1.2",
"timestamp": "2018-12-13T17:00:00Z",
"organization": "IETF NETMOD Working Group",
"contact" : "WG Web: http://tools.ietf.org/wg/netmod/,
WG List: mailto:[email protected]",
"description": "Example IETF network device YANG package.

This package defines a small sample set of
YANG modules that could represent the basic set of
modules that a standard network device might be expected
to support.",
"reference": "XXX, draft-rwilton-netmod-yang-packages",
"location": [ "file://example.org/yang/packages/
[email protected]" ],
"module": [
{

Wilton, et al. Expires 28 April 2023 [Page 46]

Internet-Draft YANG Packages October 2022

           "name": "iana-crypt-hash",
           "revision": "2014-08-06",
           "location": [ "https://tiny.cc/ietf-yang/\
                               iana-crypt-hash%402014-08-06.yang" ],
         },
         {
           "name": "ietf-system",
           "revision": "2014-08-06",
           "location": [ "https://tiny.cc/ietf-yang/\
                                   ietf-system%402014-08-06.yang" ],
         },
         {
           "name": "ietf-interfaces",
           "revision": "2018-02-20",
           "location": [ "https://tiny.cc/ietf-yang/\
                               ietf-interfaces%402018-02-20.yang" ],
         },
         {
           "name": "ietf-netconf-acm",
           "revision": "2018-02-14",
           "location": [ "https://tiny.cc/ietf-yang/\
                              ietf-netconf-acm%402018-02-14.yang" ],
         },
         {
           "name": "ietf-key-chain",
           "revision": "2017-06-15",
           "location": [ "https://tiny.cc/ietf-yang/\
                                  [email protected]" ],
         },
         {
           "name": "ietf-ip",
           "revision": "2018-02-22",
           "location": [ "https://tiny.cc/ietf-yang/\
                                       ietf-ip%402018-02-22.yang" ],
       }
       ],
       "import-only-module": [
         {
           "name": "ietf-yang-types",
           "revision": "2013-07-15",
           "location": [ "https://tiny.cc/ietf-yang/\
                               ietf-yang-types%402013-07-15.yang" ],
         },
         {
           "name": "ietf-inet-types",
           "revision": "2013-07-15",
           "location": [ "https://tiny.cc/ietf-yang/\
                               ietf-inet-types%402013-07-15.yang" ],

Wilton, et al. Expires 28 April 2023 [Page 47]

Internet-Draft YANG Packages October 2022

         }
       ]
     }
   }
 }

}