Skip to content

Commit b7fedce

Browse files
committed
Remove DB creation from the MySQL tests
1 parent 3414d19 commit b7fedce

File tree

3 files changed

+14
-15
lines changed

3 files changed

+14
-15
lines changed

.travis.yml

+2-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@ before_script:
2222
- sudo cp ./pg_hba.conf /etc/postgresql/9.2/main
2323
- sudo /etc/init.d/postgresql start
2424
- psql -c 'create database model_test;' -U postgres
25-
- sudo apt-get install mysql-server
25+
- sudo apt-get install mysql-server mysql-client
26+
- mysql -u root -e "CREATE DATABASE model_test COLLATE latin1_general_cs;"
2627
- sudo apt-get install sqlite3 libsqlite3-dev
2728

2829
script: jake test

lib/adapters/sql/mysql.js

+7-1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ _baseConfig = {
1212
host: 'localhost'
1313
, user: process.env.USER
1414
, password: null
15+
, database: process.env.USER
1516
};
1617

1718
Adapter = function (options) {
@@ -42,7 +43,12 @@ utils.mixin(Adapter.prototype, new (function () {
4243
this.connect = function () {
4344
var self = this;
4445
this.client.connect(function () {
45-
self.emit('connect');
46+
self.exec('USE ' + self.config.database, function (err, data) {
47+
if (err) {
48+
throw err;
49+
}
50+
self.emit('connect');
51+
});
4652
});
4753
};
4854

test/integration/adapters/sql/mysql.js

+5-13
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,11 @@ tests = {
1919
adapter = new Adapter({
2020
user: 'root'
2121
, multipleStatements: true
22+
, database: 'model_test'
2223
});
2324
adapter.once('connect', function () {
2425
var sql = '';
2526

26-
sql += 'DROP DATABASE IF EXISTS model_test;';
27-
sql += 'CREATE DATABASE model_test COLLATE latin1_general_cs;';
28-
sql += 'USE model_test;';
2927
sql += generator.dropTable(relations);
3028
sql += generator.createTable(relations);
3129

@@ -50,16 +48,10 @@ tests = {
5048
}
5149

5250
, 'after': function (next) {
53-
var sql = 'DROP DATABASE IF EXISTS model_test;';
54-
adapter.exec(sql, function (err, data) {
55-
if (err) {
56-
throw err;
57-
}
58-
adapter.once('disconnect', function () {
59-
next();
60-
});
61-
adapter.disconnect();
62-
});
51+
adapter.once('disconnect', function () {
52+
next();
53+
});
54+
adapter.disconnect();
6355
}
6456

6557
, 'test create adapter': function () {

0 commit comments

Comments
 (0)