Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list of supported types of mechanisms to NetworkServiceEndpoint entry #85

Open
denis-tingaikin opened this issue Apr 2, 2021 · 6 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@denis-tingaikin
Copy link
Member

denis-tingaikin commented Apr 2, 2021

Description

We can add the SupportedMechanisms field into NetworkServiceEndpoint to directly indicate what kinds of mechanisms the Endpoint could handle.

SupportedMechanisms is a list of Mechanisms kind, such as 'MEMIF', 'KERNEL', and so on.

Motivation

This can reduce the count of NSMgr tries on selecting cross-nse or nse. It can make Request for the Connection much faster on load. (NSMgr could just filter all NSEs from the registry before do Request to the next point)

Closes networkservicemesh/sdk#802

@denis-tingaikin denis-tingaikin added question Further information is requested help wanted Extra attention is needed labels Apr 2, 2021
@denis-tingaikin
Copy link
Member Author

The main questions are:

  1. Can we face side effects?
  2. What should we do on registering NSE which have not SupportedMechanisms?

@edwarnicke
Copy link
Member

  1. Does this potentially have application to the point to multipoint discussion?

@denis-tingaikin
Copy link
Member Author

denis-tingaikin commented Apr 3, 2021

  1. What should we do on registering NSE which have not SupportedMechanisms?

For this case, we could just reject the incoming request on the registry side.

  1. Can we face side effects?

Currently, I see only fields that can be improved. I.e. no more permutation on selecting NSE/cross-NSE and also this should reduce requests count to the registry from nsmgr. Also, third-party apps that using the registry API could fast find NSEs that support specific mechanisms.

@denis-tingaikin
Copy link
Member Author

/cc @fkautz

@denis-tingaikin
Copy link
Member Author

@edwarnicke Do we have any updates on this?

@edwarnicke
Copy link
Member

@denis-tingaikin Not yet... but I'll leave it in my notifications so I make sure to circle back to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants