Skip to content

Commit 99c8a0e

Browse files
authored
Merge pull request #2930 from jimklimov/issue-2744-cosmetic
tests/Makefile.am: restructure and comment cppunittest_LDADD and cppnit_LDADD
2 parents 9d05ac9 + 1c47511 commit 99c8a0e

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

tests/Makefile.am

+5-3
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,12 @@ TESTS += $(TESTS_CXX11)
152152
# Note: we only build it, but do not run directly (NIT prepares the sandbox)
153153
check_PROGRAMS += cppnit
154154

155+
# NOTE: libnutclientstub includes libnutclient and adds nutclientmem
155156
cppunittest_CXXFLAGS = $(AM_CXXFLAGS) $(CPPUNIT_CFLAGS) $(CPPUNIT_CXXFLAGS) $(CPPUNIT_NUT_CXXFLAGS) $(CXXFLAGS)
156157
###cppunittest_CXXFLAGS += -I$(top_srcdir)/include -DTOP_SRCDIR="\"$(top_srcdir)\""
157158
cppunittest_LDFLAGS = $(CPPUNIT_LDFLAGS) $(CPPUNIT_LIBS)
158-
cppunittest_LDADD = $(top_builddir)/clients/libnutclient.la
159-
cppunittest_LDADD += $(top_builddir)/clients/libnutclientstub.la
159+
cppunittest_LDADD = $(top_builddir)/clients/libnutclientstub.la
160+
cppunittest_LDADD += $(top_builddir)/clients/libnutclient.la
160161
cppunittest_SOURCES = $(CPPUNITTESTSRC) $(CPPUNITTESTERSRC)
161162

162163
# Currently nutconf and related codebase causes woes for static analysis
@@ -168,7 +169,8 @@ endif WITH_LIBNUTCONF
168169

169170
cppnit_CXXFLAGS = $(AM_CXXFLAGS) $(CPPUNIT_CFLAGS) $(CPPUNIT_CXXFLAGS) $(CPPUNIT_NUT_CXXFLAGS) $(CXXFLAGS)
170171
cppnit_LDFLAGS = $(CPPUNIT_LDFLAGS) $(CPPUNIT_LIBS)
171-
cppnit_LDADD = $(top_builddir)/clients/libnutclient.la $(top_builddir)/clients/libnutclientstub.la
172+
cppnit_LDADD = $(top_builddir)/clients/libnutclientstub.la
173+
cppnit_LDADD += $(top_builddir)/clients/libnutclient.la
172174
cppnit_SOURCES = $(CPPCLIENTTESTSRC) $(CPPUNITTESTERSRC)
173175

174176
# Make sure out-of-dir C++ dependencies exist (especially when dev-building

0 commit comments

Comments
 (0)