add new detector

Author: DominiqueMakowski

neurokit2/ecg/ecg_clean.py

@@ -233,23 +233,19 @@ def _ecg_clean_pantompkins(ecg_signal, sampling_rate=1000):
 
 
 # =============================================================================
-# Elgendi et al. (2010)
+# Hamilton (2002)
 # =============================================================================
-def _ecg_clean_elgendi(ecg_signal, sampling_rate=1000):
-    """From https://github.com/berndporr/py-ecg-detectors/
-
-    - Elgendi, Mohamed & Jonkman, Mirjam & De Boer, Friso. (2010). Frequency Bands Effects on QRS
-      Detection. The 3rd International Conference on Bio-inspired Systems and Signal Processing
-      (BIOSIGNALS2010). 428-431.
-
+def _ecg_clean_hamilton(ecg_signal, sampling_rate=1000):
+    """Adapted from https://github.com/PIA-
+    Group/BioSPPy/blob/e65da30f6379852ecb98f8e2e0c9b4b5175416c3/biosppy/signals/ecg.py#L69.
     """
 
-    order = 2
+    order = 1
     clean = signal_filter(
         signal=ecg_signal,
         sampling_rate=sampling_rate,
         lowcut=8,
-        highcut=20,
+        highcut=16,
         method="butterworth_zi",
         order=order,
     )
@@ -258,19 +254,23 @@ def _ecg_clean_elgendi(ecg_signal, sampling_rate=1000):
 
 
 # =============================================================================
-# Hamilton (2002)
+# Elgendi et al. (2010)
 # =============================================================================
-def _ecg_clean_hamilton(ecg_signal, sampling_rate=1000):
-    """Adapted from https://github.com/PIA-
-    Group/BioSPPy/blob/e65da30f6379852ecb98f8e2e0c9b4b5175416c3/biosppy/signals/ecg.py#L69.
+def _ecg_clean_elgendi(ecg_signal, sampling_rate=1000):
+    """From https://github.com/berndporr/py-ecg-detectors/
+
+    - Elgendi, Mohamed & Jonkman, Mirjam & De Boer, Friso. (2010). Frequency Bands Effects on QRS
+      Detection. The 3rd International Conference on Bio-inspired Systems and Signal Processing
+      (BIOSIGNALS2010). 428-431.
+
     """
 
-    order = 1
+    order = 2
     clean = signal_filter(
         signal=ecg_signal,
         sampling_rate=sampling_rate,
         lowcut=8,
-        highcut=16,
+        highcut=20,
         method="butterworth_zi",
         order=order,
     )