Skip to content

Commit 65fde63

Browse files
dpacheconrclaude
andcommitted
feat(nr-ebpf-agent): add global.images.pullSecrets support to daemonsets
Update imagePullSecrets rendering in both daemonsets to cascade from global.images.pullSecrets: - Updated nr-ebpf-agent-daemonset.yaml to include global.images.pullSecrets - Updated otel-collector-daemonset.yaml to include global.images.pullSecrets - Both use common library renderPullSecrets helper with concat Configuration hierarchy: 1. global.images.pullSecrets (applied first - highest priority) 2. pullSecrets (chart level - applied second) Both sources are concatenated to support flexible secret management. 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
1 parent b2dfe5f commit 65fde63

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

charts/nr-ebpf-agent/templates/nr-ebpf-agent-daemonset.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ spec:
3030
{{- with include "newrelic.common.priorityClassName" . }}
3131
priorityClassName: {{ . }}
3232
{{- end }}
33-
{{- with include "newrelic.common.images.renderPullSecrets" ( dict "pullSecrets" (list .Values.pullSecrets) "context" .) }}
33+
{{- $globalPullSecrets := .Values.global.images.pullSecrets | default list }}
34+
{{- with include "newrelic.common.images.renderPullSecrets" ( dict "pullSecrets" (concat $globalPullSecrets (list .Values.pullSecrets)) "context" .) }}
3435
imagePullSecrets:
3536
{{- . | nindent 8 }}
3637
{{- end }}

charts/nr-ebpf-agent/templates/otel-collector-daemonset.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,8 @@ spec:
3333
{{- with include "newrelic.common.priorityClassName" . }}
3434
priorityClassName: {{ . }}
3535
{{- end }}
36-
{{- with include "newrelic.common.images.renderPullSecrets" ( dict "pullSecrets" (list .Values.pullSecrets) "context" .) }}
36+
{{- $globalPullSecrets := .Values.global.images.pullSecrets | default list }}
37+
{{- with include "newrelic.common.images.renderPullSecrets" ( dict "pullSecrets" (concat $globalPullSecrets (list .Values.pullSecrets)) "context" .) }}
3738
imagePullSecrets:
3839
{{- . | nindent 8 }}
3940
{{- end }}

0 commit comments

Comments
 (0)