Add test case to update metadata

Author: abhishuraina

pkg/entity/register/worker.go

@@ -106,6 +106,13 @@ func (w *worker) Run(ctx context.Context) {
 		}
 	}
 }
+func updateEntityMetadata(entity *entity.Fields, labels map[string]string) {
+	if len(labels) > 0 {
+		for key, value := range labels {
+			entity.Metadata[key] = value
+		}
+	}
+}
 
 func (w *worker) send(ctx context.Context, batch map[entity.Key]fwrequest.EntityFwRequest, batchSizeBytes *int) {
 	defer w.resetBatch(batch, batchSizeBytes)
@@ -114,11 +121,7 @@ func (w *worker) send(ctx context.Context, batch map[entity.Key]fwrequest.Entity
 	for _, r := range batch {
 		entity := r.Data.Entity
 		// Add labels to Metadata
-		if r.Definition.Labels != nil && len(r.Definition.Labels) > 0 {
-			for key, value := range r.Definition.Labels {
-				entity.Metadata[key] = value
-			}
-		}
+		updateEntityMetadata(&entity, r.Definition.Labels)
 		entities = append(entities, entity)
 	}
 

pkg/entity/register/worker_test.go

@@ -566,3 +566,28 @@ func TestWorker_send_Logging_VerboseDisabled(t *testing.T) {
 
 	assert.Empty(t, hook.AllEntries())
 }
+func TestUpdateEntityMetadata(t *testing.T) {
+	expected := &entity.Fields{
+		Name:         "WIN_SERVICE:testWindows:newrelic-infra",
+		Type:         "WIN_SERVICE",
+		IDAttributes: nil,
+		DisplayName:  "New Relic Infrastructure Agent",
+		Metadata: map[string]interface{}{
+			"environment": "dev",
+			"backup":      "true",
+		},
+	}
+	labels := map[string]string{
+		"environment": "dev",
+		"backup":      "true",
+	}
+	entity := &entity.Fields{
+		Name:         "WIN_SERVICE:testWindows:newrelic-infra",
+		Type:         "WIN_SERVICE",
+		IDAttributes: nil,
+		DisplayName:  "New Relic Infrastructure Agent",
+		Metadata:     map[string]interface{}{},
+	}
+	updateEntityMetadata(entity, labels)
+	assert.Equal(t, expected, entity)
+}