Merge branch 'main' into feature/hybrid-agent-metrics

Author: tippmar-nr

.github/workflows/pr-title-checker-config.json

@@ -3,7 +3,7 @@
       "name": ""
     },
     "CHECKS": {
-      "regexp": "^(fix|feat|security|notice|chore|ci|docs|test|summary)(\([^)]+\))?: "
+      "regexp": "^(fix|feat|security|notice|chore|ci|docs|test|summary)(\\([^)]+\\))?: "
     },
     "MESSAGES": {
       "success": "Pull request title is properly formatted.",

.github/workflows/pr_title_checker.yml

@@ -24,9 +24,13 @@ jobs:
         with:
           disable-sudo: true
           egress-policy: audit
+      - name: Checkout
+        uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
+        with:
+          fetch-depth: 0
       - name: Check PR title    
         uses: thehanimo/pr-title-checker@7fbfe05602bdd86f926d3fb3bccb6f3aed43bc70 # v1.4.3
         with:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           pass_on_octokit_error: false
-          configuration_path: .github/workflows/pr-title-checker-config.json
+          local_configuration_path: .github/workflows/pr-title-checker-config.json

src/Agent/NewRelic/Agent/Core/OpenTelemetryBridge/ActivityBridgeSegmentHelpers.cs

@@ -145,13 +145,13 @@ private static void ProcessRpcClientTags(ISegment segment, IAgent agent, IErrorS
         tags.TryGetAndRemoveTag<string>(["grpc.method"], out var grpcMethod);
 
         tags.TryGetAndRemoveTag<string>(["server.address", "network.peer.address"], out var host);
-        tags.TryGetAndRemoveTag<int>(["server.port", "network.peer.port"], out var port);
+        tags.TryGetAndRemoveTag<int?>(["server.port", "network.peer.port"], out var port);
 
         // TODO: Otel tracing spec says "component" should be set to the rpc system, but the grpc spec makes no mention of it.
         // TODO: ExternalSegmentData curently sets Component as an Intrinsic attribute on the span, with a value of _segmentData.TypeName (which ends up being `NewRelic.Agent.Core.OpenTelemetryBridge.ActivityBridge`)  with no override available. So there's no way for us to set the same attribute with a different value.
         //segment.AddCustomAttribute("component", rpcSystem);
 
-        var path = BuildRpcPath(host, port, service, method, grpcMethod);
+        var path = BuildRpcPath(host ?? "unknown", port ?? 0, service, method, grpcMethod);
         Uri uri = new Uri(path);
         var externalSegmentData = new ExternalSegmentData(uri, method);
 
@@ -195,7 +195,7 @@ private static void ProcessRpcServerTags(ISegment segment, IAgent agent, IErrorS
 
         var transaction = hybridAgentSegment.GetTransactionFromSegment();
 
-        var path = BuildRpcPath(host, port, service, method, grpcMethod);
+        var path = BuildRpcPath(host ?? "unknown", port ?? 0, service, method, grpcMethod);
         transaction.SetUri(path);
 
         transaction.SetRequestMethod(method ?? grpcMethod ?? "Unknown"); // TODO: should we default to "Unknown" or leave it null?