Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing line-break after message "Warning: Removing recursively:" #640

Open
goran-w opened this issue Feb 5, 2025 · 0 comments
Open

Missing line-break after message "Warning: Removing recursively:" #640

goran-w opened this issue Feb 5, 2025 · 0 comments

Comments

@goran-w
Copy link
Contributor

goran-w commented Feb 5, 2025

Issue: The following print-out message is missing a terminating line-break and gets jumbled with other text:
Warning: Removing recursively: <filename>

Location in source-code: https://github.com/newren/git-filter-repo/blob/main/git-filter-repo#L2906

Example output:

Processed 28217 blob sizesely: ".git\filter-repo\analysis"
Processed 1129 commits
Writing reports to .git\filter-repo\analysis...done.

(Notice how the words sizes and recursively get combined into sizesely on the first line, due to repeatedly overwritten runtime progress reports... This would be solved by adding the missing line-break.)

Adding the missing newline will correct the output:

Warning: Removing recursively: ".git\filter-repo\analysis"
Processed 28217 blob sizes
Processed 1129 commits
Writing reports to .git\filter-repo\analysis...done.
@goran-w goran-w changed the title Missing line-break after message "Warning: Removing recursively: ..." Missing line-break after message "Warning: Removing recursively:" Feb 5, 2025
goran-w added a commit to goran-w/git-filter-repo that referenced this issue Feb 19, 2025
goran-w added a commit to goran-w/git-filter-repo that referenced this issue Feb 19, 2025
goran-w added a commit to goran-w/git-filter-repo that referenced this issue Feb 19, 2025
Fixes issue reported in newren#640.

Signed-off-by: goran-w <[email protected]>
goran-w added a commit to goran-w/git-filter-repo that referenced this issue Feb 19, 2025
Fixes issue reported in newren#640:

The following print-out message is missing a terminating line-break and gets jumbled with other text:
Warning: Removing recursively: <filename>

Example output:
```
Processed 28217 blob sizesely: ".git\filter-repo\analysis"
Processed 1129 commits
Writing reports to .git\filter-repo\analysis...done.
```

(Notice how the words sizes and recursively get combined into sizesely on the first line, due to repeatedly overwritten runtime progress reports... This would be solved by adding the missing line-break.)

Adding the missing newline will correct the output:
```
Warning: Removing recursively: ".git\filter-repo\analysis"
Processed 28217 blob sizes
Processed 1129 commits
Writing reports to .git\filter-repo\analysis...done.
```

Signed-off-by: goran-w <[email protected]>
goran-w added a commit to goran-w/git-filter-repo that referenced this issue Feb 19, 2025
Fix jumbled printout (as reported in issue newren#640) :

The following print-out message is missing a terminating line-break and gets partially overwritten by other text:

Warning: Removing recursively: <filename>

Example output:

Processed 28217 blob sizesely: ".git\filter-repo\analysis"
Processed 1129 commits
Writing reports to .git\filter-repo\analysis...done.

(Notice how the words "sizes" and "recursively" get combined into "sizesely" on the first line.)

Adding the missing newline will correct the output:

Warning: Removing recursively: ".git\filter-repo\analysis"
Processed 28217 blob sizes
Processed 1129 commits
Writing reports to .git\filter-repo\analysis...done.

Signed-off-by: goran-w <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant