Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCOM Driver should warn the user if the firmware major version is higher than expected #41

Open
w4sm opened this issue Mar 16, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@w4sm
Copy link

w4sm commented Mar 16, 2021

I uploaded the 4.0.1 firmware to both my rotator and my shutter. Both reported successful uploads. However now I cannot connect to the dome. I get the attached error message every time I try. The port# is correct. I've tried cycling the power on everything with no success. I also tried reinstalling 4.0.1 and also reverting to 4.0.0 with no success, although firmware is installed correctly according to the message.
I'm stumped. The log just shows a failure to connect. I have no problems installing the firmware.

@w4sm
Copy link
Author

w4sm commented Mar 16, 2021

Problem solved. I needed to update to NexDomeControlSystem-4.0.0.exe as well as the firmware. Everything worked fine after that.

@NameOfTheDragon
Copy link
Collaborator

NameOfTheDragon commented Apr 2, 2021

I'm glad you solved your problem. It's tempting to close the issue at that point, but this is probably worth keeping in open for a future version. The ASCOM driver checks for minimum compatible firmware version but it doesn't currently check for a maximum version. Based on the rules of semantic versioning, a major version increment would indicate breaking changes in the firmware protocol. The driver should probably therefore only accept the one major version that it was tested against. It should at least warn the user and create warning log entries if the firmware major version is higher than expected.

I don't think this is high priority but I'm going to update the title of the issue and keep it open in case we make another version of the driver. Thanks for reporting this.

@NameOfTheDragon NameOfTheDragon changed the title Can't Connect after Update ASCOM Driver should warn the user if the firmware major version is higher than expected Apr 2, 2021
@NameOfTheDragon NameOfTheDragon added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants