Ability to add custom labels to aio-managed containers

[AiroPi]

Some services like Watchtower, Diun, etc.. depends on containers labels to know which containers they needs to inspect and which ones they can ignore.

By default, all containers managed by aio does have Watchtower disabled. But this is defined at Dockerfile level, it is not directly managed by AIO.

Moreover, it doesn't apply to community containers, so they can be upgraded by an external watchtower by default, which may be not ideal.

My suggestion would be to have an option to add labels to all containers managed by AIO (community and classic ones).
This could be implemented via environment variable or inherited from the Mastercontainer itself.

If I get some feedbacks, suggestions and directives, I am ready to implement such a feature myself and open a Pull Request.

In my case, I have a Diun running that notifies me when a new container version is available for one of my container, but I can't disable these notifications for AIO containers due to the lack of ability to add labels. And I don't care about new AIO versions since it is auto updated !

[szaimen]

Hi,

By default, all containers managed by aio does have Watchtower disabled. But this is defined at Dockerfile level, it is not directly managed by AIO.

Moreover, it doesn't apply to community containers, so they can be upgraded by an external watchtower by default, which may be not ideal.

Thanks for bringing this up. I agree this should be improved. See #6601.

---

My suggestion would be to have an option to add labels to all containers managed by AIO (community and classic ones). This could be implemented via environment variable or inherited from the Mastercontainer itself.

If I get some feedbacks, suggestions and directives, I am ready to implement such a feature myself and open a Pull Request.

In my case, I have a Diun running that notifies me when a new container version is available for one of my container, but I can't disable these notifications for AIO containers due to the lack of ability to add labels. And I don't care about new AIO versions since it is auto updated !

You might be able to build on #6601.

I would suggest to have one global env that is applied via env to the mastercontainer and then gets applied to all sibling containers.

And sorry for my late reply!

[szaimen]

Thanks for bringing this up. I agree this should be improved. See #6601.

This is now released with v11.3.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel

[szaimen]

My suggestion would be to have an option to add labels to all containers managed by AIO (community and classic ones). This could be implemented via environment variable or inherited from the Mastercontainer itself.
If I get some feedbacks, suggestions and directives, I am ready to implement such a feature myself and open a Pull Request.
In my case, I have a Diun running that notifies me when a new container version is available for one of my container, but I can't disable these notifications for AIO containers due to the lack of ability to add labels. And I don't care about new AIO versions since it is auto updated !

You might be able to build on #6601.

I would suggest to have one global env that is applied via env to the mastercontainer and then gets applied to all sibling containers.

Regarding this, we can add the label by default to all containers. See #6631

[szaimen]

My suggestion would be to have an option to add labels to all containers managed by AIO (community and classic ones). This could be implemented via environment variable or inherited from the Mastercontainer itself.
If I get some feedbacks, suggestions and directives, I am ready to implement such a feature myself and open a Pull Request.
In my case, I have a Diun running that notifies me when a new container version is available for one of my container, but I can't disable these notifications for AIO containers due to the lack of ability to add labels. And I don't care about new AIO versions since it is auto updated !

You might be able to build on #6601.
I would suggest to have one global env that is applied via env to the mastercontainer and then gets applied to all sibling containers.

Regarding this, we can add the label by default to all containers. See #6631

This is now released with v11.4.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel