Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Remove dev dependency on nextcloud/ocp #1547

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Oct 23, 2024

Only needed for psalm checks, which got moved to its own vendor-bin environment.

This reverts commit df190af.

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo- mejo- added bug Something isn't working 2. developing dependencies labels Oct 23, 2024
@mejo- mejo- self-assigned this Oct 23, 2024
Only needed for psalm checks, which got moved to its own vendor-bin
environment.

This reverts commit df190af.

Signed-off-by: Jonas <[email protected]>
@max-nextcloud
Copy link
Collaborator

Maybe add a .git-blame-ignore-refs file and add the code style fixes commit to it like in https://github.com/nextcloud-libraries/eslint-config/pull/854/files

@mejo-
Copy link
Member Author

mejo- commented Oct 23, 2024

Maybe add a .git-blame-ignore-refs file and add the code style fixes commit to it like in https://github.com/nextcloud-libraries/eslint-config/pull/854/files

Interesting, didn't know about this feature. But it feels a bit off to start this now with a rather small code style commit. Maybe instead do a separate PR that adds all recent code style commits to this file?

@mejo- mejo- merged commit 5a0389b into main Oct 25, 2024
51 of 53 checks passed
@mejo- mejo- deleted the fix/remove_nextcloud_ocp branch October 25, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working dependencies
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants