Skip to content

Commit f4a03c1

Browse files
committed
chore(ignoredfiles): remove unused readOnlyTooltip
The tool tip was wrong anyway -- system entries could be modified for a long time already. I would rather figure out a nicer way to display why a certain rule appears in the list at a glance Signed-off-by: Jyrki Gadinger <[email protected]>
1 parent 62b439e commit f4a03c1

File tree

4 files changed

+0
-7
lines changed

4 files changed

+0
-7
lines changed

src/gui/ignorelisteditor.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,6 @@ IgnoreListEditor::IgnoreListEditor(QWidget *parent)
2828
ui->setupUi(this);
2929

3030
ConfigFile cfgFile;
31-
//FIXME This is not true. The entries are hardcoded below in setupTableReadOnlyItems
32-
readOnlyTooltip = tr("This entry is provided by the system at \"%1\" "
33-
"and cannot be modified in this view.")
34-
.arg(QDir::toNativeSeparators(cfgFile.excludeFile(ConfigFile::SystemScope)));
3531

3632
setupTableReadOnlyItems();
3733
const auto userConfig = cfgFile.excludeFile(ConfigFile::Scope::UserScope);

src/gui/ignorelisteditor.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ private slots:
3737

3838
private:
3939
void setupTableReadOnlyItems();
40-
QString readOnlyTooltip;
4140
Ui::IgnoreListEditor *ui;
4241
};
4342

src/gui/ignorelisttablewidget.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,6 @@ int IgnoreListTableWidget::addPattern(const QString &pattern, const bool deletab
181181

182182
if (readOnly) {
183183
patternItem->setFlags(patternItem->flags() ^ Qt::ItemIsEnabled);
184-
patternItem->setToolTip(readOnlyTooltip);
185184
deletableItem->setFlags(deletableItem->flags() ^ Qt::ItemIsEnabled);
186185
}
187186

src/gui/ignorelisttablewidget.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ private slots:
3737

3838
private:
3939
void setupTableReadOnlyItems();
40-
QString readOnlyTooltip;
4140
Ui::IgnoreListTableWidget *ui;
4241
};
4342
} // namespace OCC

0 commit comments

Comments
 (0)