Guests created via Talk don't receive a welcome mail

[SystemKeeper]

Steps to reproduce:

• Create a talk conversation
• Enter a mail address in the share tab and select "Invite guest"
• In the modal add name and create the guest

Expected:

• The guest receives a mail that he was invited to a talk conversation and has the ability to reset the password

Current:

• No mail is send to the guest, so the person who created the guest needs to manually reach out to them and tell them to use the "Reset password" functionality to create the credentials

Additional:
Creating guests via file share is working correctly, the guest receive a mail. This is done inside the Hook.php: https://github.com/nextcloud/guests/blob/master/lib/Hooks.php

[nickvergessen]

Talk is using the PUT ocs/v2.php/…/api/v1/users endpoint, but yeah the GuestManager doesn't seem to send an email there.
It only generates the password reset token:

guests/lib/GuestManager.php

Lines 104 to 155 in 0ab2d2b

	public function createGuest(IUser $createdBy, string $userId, string $email, string $displayName = '', string $language = '', ?string $initialPassword = null) : IUser {
	if ($initialPassword === null) {
	$passwordEvent = new GenerateSecurePasswordEvent();
	$this->eventDispatcher->dispatchTyped($passwordEvent);
	$password = $passwordEvent->getPassword() ?? $this->secureRandom->generate(20);
	} else {
	$password = $initialPassword;
	}
	/** @var IUser */
	$user = $this->userManager->createUserFromBackend(
	$userId,
	$password,
	$this->userBackend
	);
	$user->setEMailAddress($email);
	$this->config->setUserValue($userId, 'guests', 'created_by', $createdBy->getUID());
	if ($displayName) {
	$user->setDisplayName($displayName);
	}
	if ($language) {
	$this->config->setUserValue($userId, 'core', 'lang', $language);
	}
	if ($initialPassword === null) {
	// generate token for lost password so that a link can be sent by email
	$token = $this->secureRandom->generate(
	21,
	ISecureRandom::CHAR_DIGITS .
	ISecureRandom::CHAR_LOWER .
	ISecureRandom::CHAR_UPPER);
	$endOfTime = PHP_INT_MAX - 50000;
	$token = sprintf('%s:%s', $endOfTime, $token);
	$encryptedValue = $this->crypto->encrypt($token, strtolower($email) . $this->config->getSystemValue('secret'));
	$this->config->setUserValue(
	$userId,
	'core',
	'lostpassword',
	$encryptedValue
	);
	}
	$user->setQuota('0 B');
	return $user;
	}

So also guests created via OCC don't receive their email atm.

[SystemKeeper]

So I guess we need to move the mail logic to the GuestManager instead of reacting to a share hook?

[nickvergessen]

not move (it's in a MailService), but just invoke that one also from the GuestManager, yes, and then skip in the email parts that refer to a share, I guess

[SystemKeeper]

Yes, that what I meant. Poor wording, sorry.

[Th3l5D]

Hello,

Still have this issue here. Is there any fix in backlog for this?

[Th3l5D]

Hey again,

I'm affraid this issue will fall in a black hole :D

Do you think it will be taken in account at some point?

[RTechSn]

It's a really needed feature.