[5.0.0-dev] Since NC32: Controller OCA\Notifications\Controller\EndpointController::listNotifications executed 121 queries.

[dartcafe]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Steps to reproduce

Expected behaviour

The warning should be more verbose to be able to understand, what it is about and what is to do.

Actual behaviour

Every 30 seconds a warning is written to the server log file without further explanation.

Server configuration

Web server: Apache

Database: MySQL

PHP version: 8.3

Nextcloud version: 32

List of activated apps

Enabled:
  - activity: 5.0.0-dev.0
  - admin_audit: 1.22.0
  - app_api: 32.0.0-dev.5
  - bruteforcesettings: 5.0.0-dev.0
  - calendar: 6.0.0-rc.2
  - circles: 32.0.0-dev.0
  - cloud_federation_api: 1.16.0
  - comments: 1.22.0
  - contacts: 8.0.0-rc.1
  - contactsinteraction: 1.13.0
  - dashboard: 7.12.0
  - dav: 1.34.2
  - deck: 1.16.0-beta.1
  - federatedfilesharing: 1.22.0
  - federation: 1.22.0
  - files: 2.4.0
  - files_downloadlimit: 5.0.0-dev.0
  - files_reminders: 1.5.0
  - files_sharing: 1.24.0
  - files_trashbin: 1.22.0
  - files_versions: 1.25.0
  - guests: 4.5.1
  - logreader: 5.0.0-dev.0
  - lookup_server_connector: 1.20.0
  - mail: 5.4.0
  - nextcloud_announcements: 4.0.0-dev.0
  - notes: 4.12.3
  - notifications: 5.0.0-dev.0
  - oauth2: 1.20.0
  - password_policy: 4.0.0-dev.0
  - polls: 8.4.6
  - profile: 1.1.0
  - provisioning_api: 1.22.0
  - recommendations: 5.0.0-dev.0
  - related_resources: 3.0.0-dev.0
  - serverinfo: 4.0.0-dev.0
  - settings: 1.15.0
  - sharebymail: 1.22.0
  - spreed: 22.0.0-rc.1
  - support: 4.0.0-dev.0
  - systemtags: 1.22.0
  - text: 6.0.0-dev.0
  - theming: 2.7.0
  - twofactor_backupcodes: 1.21.0
  - updatenotification: 1.22.0
  - user_status: 1.12.0
  - viewer: 5.0.0-dev.0
  - weather_status: 1.12.0
  - webhook_listeners: 1.3.0
  - workflowengine: 2.14.0
Disabled:
  - calendar_resource_management: 0.10.0 (installed 0.10.0)
  - collectives: 3.1.2 (installed 3.1.2)
  - encryption: 2.20.0 (installed 2.11.0)
  - files_external: 1.24.0 (installed 1.13.0)
  - files_pdfviewer: 5.0.0-dev.0 (installed 2.8.0)
  - files_rightclick: 0.15.1 (installed 1.6.0)
  - firstrunwizard: 5.0.0-dev.0 (installed 2.10.0)
  - forms: 5.2.0-beta.1 (installed 5.2.0-beta.1)
  - impersonate: 3.0.0 (installed 3.0.0)
  - integration_mattermost: 2.1.1 (installed 2.1.1)
  - login_notes: 1.6.1 (installed 1.6.1)
  - photos: 5.0.0-dev.1 (installed 1.7.1)
  - privacy: 4.0.0-dev.0 (installed 1.11.0)
  - survey_client: 4.0.0-dev.0 (installed 1.6.0)
  - suspicious_login: 10.0.0-dev.0 (installed 4.3.0)
  - tables: 1.0.0-beta.3 (installed 1.0.0-beta.3)
  - talk_simple_poll: 1.3.1 (installed 1.3.1)
  - tasks: 0.16.1 (installed 0.16.1)
  - twofactor_nextcloud_notification: 6.0.0-dev.0
  - twofactor_totp: 14.0.0
  - twofactor_webauthn: 2.3.1 (installed 2.3.1)
  - unsplash: 3.1.0 (installed 3.1.0)
  - user_ldap: 1.23.0 (installed 1.13.0)

Nextcloud configuration

{
    "system": {
        "projects.enabled": false,
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "dev.yagst.de"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "tempdirectory": "\/tmp\/foo.com\/nextcloud",
        "dbtype": "mysql",
        "version": "32.0.0.9",
        "overwrite.cli.url": "https:\/\/foo.com",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "default_language": "de",
        "default_phone_region": "DE",
        "maintenance": false,
        "theme": "",
        "loglevel": 1,
        "updater.release.channel": "beta",
        "htaccess.RewriteBase": "\/",
        "htaccess.IgnoreFrontController": true,
        "app_install_overwrite": [
            "deck",
            "spreed",
            "impersonate",
            "dashboard",
            "circles",
            "talk_simple_poll",
            "polls",
            "calendar",
            "contacts",
            "unsplash",
            "richdocumentscode",
            "spgverein",
            "collectives",
            "tasks"
        ],
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauth": true,
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauthtype": "LOGIN",
        "mail_send_plaintext_only": false,
        "ldapIgnoreNamingRules": false,
        "maintenance_window_start": 3,
        "mail_smtpport": "587",
        "defaultapp": "polls,dashboard,files",
        "debug": true
    }
}

Browser

Browser name: Firefox
Browser version: 142
Operating system: Ubuntu

Server log

{
  "reqId": "aMEU41hb9T7EmyRGVsoAAAQBI",
  "level": 2,
  "time": "2025-09-10T06:04:19+00:00",
  "remoteAddr": "pft",
  "user": "me",
  "app": "notifications",
  "method": "GET",
  "url": "/ocs/v2.php/apps/notifications/api/v2/notifications",
  "message": "Controller OCA\\Notifications\\Controller\\EndpointController::listNotifications executed 121 queries.",
  "userAgent": "Mozilla/5.0 (X11; Linux x86_64; rv:143.0) Gecko/20100101 Firefox/143.0",
  "version": "32.0.0.9",
  "data": {
    "app": "notifications"
  },
  "id": "68c114ee56128"
}

[dartcafe]

If it is a warning, it should explain. If it is just an information, the log level should maybe changed to info or debug.

[nickvergessen]

It's a warning on general server performance:
https://github.com/nextcloud/server/blob/aab11d35d3a6dad092c780e47c3fb76979d8d30d/lib/private/AppFramework/Http/Dispatcher.php#L133-L139

In this case the problem is not the notifications app directly, but the question is which notifications are being rendered for the affected user. Could you let us know the result of the following query (replace 42 with the user ID of the affected user)?

SELECT app, subject FROM oc_notifications WHERE user = '42' ORDER BY notification_id DESC LIMIT 25;

[dartcafe]

31 records without LIMIT 25.

Now: Controller OCA\Notifications\Controller\EndpointController::listNotifications executed 107 queries.

[
  {
    "type": "header",
    "version": "4.9.11",
    "comment": "Export to JSON plugin for PHPMyAdmin",
  },
  { "type": "database", "name": "nc" },
  {
    "type": "table",
    "name": "oc_notifications",
    "database": "nc",
    "data": [
      { "app": "updatenotification", "subject": "update_available" },
      { "app": "updatenotification", "subject": "update_available" },
      { "app": "updatenotification", "subject": "update_available" },
      { "app": "updatenotification", "subject": "update_available" },
      { "app": "updatenotification", "subject": "update_available" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "dav", "subject": "object_update_event" },
      { "app": "dav", "subject": "object_add_event" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
      { "app": "polls", "subject": "vote_set" },
    ],
  },
]

[nickvergessen]

Looks like https://github.com/nextcloud/polls/blob/main/lib/Notification/Notifier.php should try to group loading the polls in 1 query instead of many.
This feature was recently added with IPreloadableNotifier

[dartcafe]

But is it worth a warning level? I get an entry every 30 seconds for every active client.

[nickvergessen]

well it's a bit unfortunate yeah, but at some point we should warn. it starts at 100 queries. If every user would trigger 100 queries on requests you have other problems then a warning in the log :P

[dartcafe]

Right. But the problem existed before NC32. And implementing IPreloadableNotifier requires NC32. But the latest Polls version supports Nextcloud 31+

[nickvergessen]

Yeah, but that is the solution from notification side. Not a lot this app can do against. I also would assume that there is a chance that all those notifications are not from 18 different Polls, then it shouldn't be that many queries either?
Is there a chance that you can cache the polls or store the objects in memory for reuse in other notification parsings in the same request? Talk is e.g. doing the same with rooms: https://github.com/nextcloud/spreed/blob/main/lib/Notification/Notifier.php#L126-L157

[dartcafe]

I will look at this. But maybe the warning message could have a hint and mention the favourable IPreloadableNotifier.

For the moment I switched to Error level on my test instance.

[nickvergessen]

But maybe the warning message could have a hint and mention the favourable IPreloadableNotifier

The warning is general and done for any controller, not related/specific to the notification one. So not really sure it can hint to that. But I will think about a possible logging inside the notification to improve this case.