Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push notifications documentation wrong #655

Open
provokateurin opened this issue Jun 7, 2020 · 6 comments
Open

Push notifications documentation wrong #655

provokateurin opened this issue Jun 7, 2020 · 6 comments

Comments

@provokateurin
Copy link
Member

The documentation about subscribing at the push proxy is wrong. It shows that you have to send a json object as body (https://github.com/nextcloud/notifications/blob/master/docs/push-v2.md#L135), but actually you have to send urlencoded parameters.
This is totally irritating and I put a lot of time into investigating why my library wasn't working.

@nickvergessen
Copy link
Member

Just for the record, unless you have a apple/android key from our developer group you can not use the push proxy

@provokateurin
Copy link
Member Author

That means I cannot create an app that gets notifications?

@nickvergessen
Copy link
Member

The thing is the push proxy needs to have the apple and android developer certificate so it is allowed to push to those devices. It would work, if you create a valid dev cert and pass it on to us, so we deploy it on the proxy. But as far as I know this would in theory allow us to push releases for your appp to the respective store. But I might be wrong?
Cc @tobiasKaminsky

@tobiasKaminsky
Copy link
Member

But as far as I know this would in theory allow us to push releases for your appp to the respective store. But I might be wrong?

This is independent. One is app store and one is firebase (push).

@provokateurin
Copy link
Member Author

Shouldn't this be moved to a separate issue?

@provokateurin
Copy link
Member Author

@nickvergessen @tobiasKaminsky I don't understand why the push proxy code is not opensource, but my solution now is implementing my own push proxy and eventually publishing it. I already get the notifications from the server so I only need to implement the push part. I don't need you to add my certificate to the official push proxy anymore. Thanks anyway

Still this issue isn't resolved so I will create a PR to fix the documentation at some point in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants