Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dismiss notification should hide directly #786

Open
PVince81 opened this issue Nov 2, 2020 · 2 comments
Open

Dismiss notification should hide directly #786

PVince81 opened this issue Nov 2, 2020 · 2 comments

Comments

@PVince81
Copy link
Member

PVince81 commented Nov 2, 2020

Steps

  1. Have some notifications present under the bell icon
  2. Open notifications dropdown
  3. Click the cross icon to dismiss a notification

Expected result

Notification disappears directly.

Actual result

Delay of 1-2 seconds until it disappears.

For a better UX, we should hide the notification right away even if the XHR call is still ongoing. Worst case we can still re-display it in case of an error.

@PVince81
Copy link
Member Author

PVince81 commented Nov 2, 2020

adding "help wanted" / junior job as the fix should be a matter of quick rewiring

@nickvergessen
Copy link
Member

I think before this it needs to be migrated to a proper vue store and have a way back, because currently it just removes the element from the local array and I don't know how it would revert that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants