fix: Properly throttle in error cases and add rate limit for public file creation

juliusknorr · backportbot[bot] · commit 2355713353d8 · 2024-11-07T09:03:19.000Z
Signed-off-by: Julius Knorr &lt;jus@bitgrid.net&gt;

[skip ci]
diff --git a/lib/Controller/DocumentAPIController.php b/lib/Controller/DocumentAPIController.php
@@ -105,10 +105,12 @@ public function create(string $mimeType, string $fileName, string $directoryPath
 			}
 		} catch (Throwable $e) {
 			$this->logger->error('Failed to create document', ['exception' => $e]);
-			return new JSONResponse([
+			$response = new JSONResponse([
 				'status' => 'error',
 				'message' => $this->l10n->t('Cannot create document')
 			], Http::STATUS_BAD_REQUEST);
+			$response->throttle();
+			return $response;
 		}
 
 		$basename = $this->l10n->t('New Document.odt');

Original file line number	Diff line number	Diff line change
`@@ -105,10 +105,12 @@ public function create(string $mimeType, string $fileName, string $directoryPath`
`105`	`105`	`}`
`106`	`106`	`} catch (Throwable $e) {`
`107`	`107`	`$this->logger->error('Failed to create document', ['exception' => $e]);`
`108`		`- return new JSONResponse([`
	`108`	`+ $response = new JSONResponse([`
`109`	`109`	`'status' => 'error',`
`110`	`110`	`'message' => $this->l10n->t('Cannot create document')`
`111`	`111`	`], Http::STATUS_BAD_REQUEST);`
	`112`	`+ $response->throttle();`
	`113`	`+ return $response;`
`112`	`114`	`}`
`113`	`115`
`114`	`116`	`$basename = $this->l10n->t('New Document.odt');`