Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smart picker not working for document sections #3957

Open
pedropintosilva opened this issue Aug 28, 2024 · 2 comments · May be fixed by #3995
Open

Smart picker not working for document sections #3957

pedropintosilva opened this issue Aug 28, 2024 · 2 comments · May be fixed by #3995
Assignees
@elzody
Labels
1. to develop Waiting for a developer bug Something isn't working regression

Comments

@pedropintosilva
Copy link
Contributor

Describe the bug
I have noticed today that the https://sdk.collaboraonline.com/docs/linking_api.html is not working: https://paste.opensuse.org/pastes/3be00af7d685 .

Peek.2024-08-28.15-45.mp4

I could reproduce this with current master and stable but also I have tried with a slightly older combination and I still get the same result:

  • COOL 24.04.4.2 git hash: fbf97e9 (E)
  • Richdocuments 8.4.3
@juliusknorr
Copy link
Member

Fails at https://github.com/nextcloud-libraries/nextcloud-dialogs/blame/144923cd026110e33e824b445dffad827b91a8b1/lib/utils/dialogs.ts#L19 as we pass in an element not a selector

@juliusknorr
Copy link
Member

We should actually use https://github.com/nextcloud-libraries/nextcloud-dialogs?tab=readme-ov-file#use-the-vue-component-directly instead

@juliusknorr juliusknorr added bug Something isn't working 1. to develop Waiting for a developer regression labels Aug 28, 2024
@elzody elzody self-assigned this Sep 6, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Sep 6, 2024
@elzody elzody moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Sep 6, 2024
@elzody elzody linked a pull request Sep 6, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elzody elzody

Labels
1. to develop Waiting for a developer bug Something isn't working regression
Projects
📝 Office team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use file picker component directly nextcloud/richdocuments
3 participants
@juliusknorr @elzody @pedropintosilva