Skip to content

Commit 819e923

Browse files
authored
Merge pull request #1021 from nextcloud/backport/terms-button
[stable27] feat: improve save terms and reset signaturies actions
2 parents 3c47433 + cfd530f commit 819e923

File tree

3 files changed

+25
-8
lines changed

3 files changed

+25
-8
lines changed

js/terms_of_service-admin.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

js/terms_of_service-admin.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/App.vue

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@
3434
:checked.sync="showOnPublicShares">
3535
{{ t('terms_of_service', 'Show on public shares') }}
3636
</NcCheckboxRadioSwitch>
37-
37+
<p class="edit-form">
38+
{{ t('terms_of_service', 'Enter or update terms of service below.. ') }}
39+
</p>
3840
<span class="form">
3941
<NcMultiselect v-model="country"
4042
:options="countryOptions"
@@ -55,7 +57,9 @@
5557
<p class="settings-hint">
5658
{{ t('terms_of_service', 'For formatting purposes Markdown is supported.') }}
5759
</p>
58-
60+
<p class="terms-descr">
61+
{{ t('terms_of_service', 'Saving the terms will update the text but will not send a notification to users. Notifications are only sent if you reset the signatories.') }}
62+
</p>
5963
<NcButton :disabled="saveButtonDisabled"
6064
@click="onSubmit">
6165
{{ saveButtonText }}
@@ -64,6 +68,9 @@
6468

6569
<NcSettingsSection v-if="hasTerms"
6670
:title="t('terms_of_service', 'Existing terms of service')">
71+
<p class="terms-descr">
72+
{{ t('terms_of_service', 'We recommend to reset signatures if legal changes were applied. For minor changes like fixing typos or correcting links, it could be left out, as it would otherwise require all users to accept the Terms of Service again.') }}
73+
</p>
6774
<NcButton :disabled="resetButtonDisabled"
6875
type="error"
6976
@click="onResetSignatories">
@@ -153,7 +160,7 @@ export default {
153160
154161
mounted() {
155162
this.saveButtonText = t('terms_of_service', 'Loading …')
156-
this.resetButtonText = t('terms_of_service', 'Reset all signatories')
163+
this.resetButtonText = t('terms_of_service', 'Reset signatories & notify users')
157164
axios
158165
.get(generateOcsUrl('/apps/terms_of_service/terms/admin'))
159166
.then(response => {
@@ -178,7 +185,7 @@ export default {
178185
})
179186
})
180187
181-
this.saveButtonText = t('terms_of_service', 'Save')
188+
this.saveButtonText = t('terms_of_service', 'Save terms')
182189
this.$nextTick(() => {
183190
this.saveButtonDisabled = false
184191
})
@@ -229,8 +236,13 @@ export default {
229236
display: block;
230237
}
231238
232-
.form {
239+
.edit-form {
233240
margin-top: 30px;
241+
opacity: .7;
242+
}
243+
244+
.form {
245+
margin-top: 10px;
234246
display: block;
235247
}
236248
@@ -245,4 +257,9 @@ label span {
245257
vertical-align: top;
246258
}
247259
260+
.terms-descr {
261+
opacity: .7;
262+
margin-bottom: 10px;
263+
}
264+
248265
</style>

0 commit comments

Comments
 (0)