Outdated country list

[rakekniven]

terms_of_service/lib/Db/Mapper/CountryMapper.php

Line 171 in 1a87120

'MK' => $this->l->t('Macedonia (the former Yugoslav Republic of)'),

Issue reported at Transifex:

Since 2019 correct country name has been North Macedonia - ref: https://en.wikipedia.org/wiki/North_Macedonia

Which list has been the source for list at "CountryMapper.php"?

git blame brought me to @nickvergessen

[nickvergessen]

Which list has been the source for list at "CountryMapper.php"?

geoip2/geoip2
But the fact that this library is not updated, is having massive problems with modern world and is not supporting IPv6 makes me think:
If we should change anything here, it's removing the region/country/… selection completely and only consider the language.

[GretaD]

ohh.. so its not a matter of manual change of CountryMapper..?

[rakekniven]

Uh, what do you think of just changing this single line first?

[nickvergessen]

git blame brought me to

And just for the record, I just reformated code, it origins from the beginning of the app:

cc355bd#diff-fa9d4b34e34e1bfb4a469d1b7100cea16ed3d4227cd40d072a75162b7cb55e4e

what do you think of just changing this single line first?

Question for the maintainer I guess. I'm not doing the app anymore. Country lists are always political problems.

[rakekniven]

Question for the maintainer I guess.

You are listed at app store ;-)

Added PR #1076

[nickvergessen]

We never update appstore entries, codeowner file will tell the truth:
https://github.com/nextcloud/terms_of_service/blob/master/.github/CODEOWNERS

[GretaD]

fixed here #1076