Skip to content

Commit 56e9e4c

Browse files
authored
fix: permissions checks for threads (#34)
1 parent 0b638fd commit 56e9e4c

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

examples/embed_pages.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@ async def format_page(self, menu, entries):
1313
embed = Embed(title="Entries")
1414
for entry in entries:
1515
embed.add_field(name=entry[0], value=entry[1], inline=True)
16-
embed.set_footer(text=f'Page {menu.current_page + 1}/{self.get_max_pages()}')
16+
embed.set_footer(text=f"Page {menu.current_page + 1}/{self.get_max_pages()}")
1717
return embed
1818

19+
1920
@bot.command()
2021
async def button_embed_field(ctx):
2122
data = [
@@ -66,18 +67,18 @@ def __init__(self, data):
6667

6768
async def format_page(self, menu, entries):
6869
embed = Embed(title="Entries", description="\n".join(entries))
69-
embed.set_footer(text=f'Page {menu.current_page + 1}/{self.get_max_pages()}')
70+
embed.set_footer(text=f"Page {menu.current_page + 1}/{self.get_max_pages()}")
7071
return embed
7172

7273

7374
@bot.command()
7475
async def button_embed_description(ctx):
75-
data = [f'Description for entry #{num}' for num in range(1, 51)]
76+
data = [f"Description for entry #{num}" for num in range(1, 51)]
7677
pages = menus.ButtonMenuPages(
7778
source=MyEmbedDescriptionPageSource(data),
7879
clear_buttons_after=True,
7980
)
8081
await pages.start(ctx)
8182

8283

83-
bot.run('token')
84+
bot.run("token")

nextcord/ext/menus/menus.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -459,7 +459,10 @@ def _verify_permissions(
459459
channel: nextcord.abc.Messageable,
460460
permissions: Permissions,
461461
):
462-
if not permissions.send_messages:
462+
is_thread = isinstance(channel, nextcord.Thread)
463+
if is_thread and not permissions.send_messages_in_threads:
464+
raise CannotSendMessages()
465+
elif not is_thread and not permissions.send_messages:
463466
raise CannotSendMessages()
464467

465468
if self.check_embeds and not permissions.embed_links:

0 commit comments

Comments
 (0)