Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use i18next translation features for measurements panel options #1826

Open
Tracked by #1463
huddlej opened this issue Aug 16, 2024 · 0 comments
Open
Tracked by #1463

Use i18next translation features for measurements panel options #1826

huddlej opened this issue Aug 16, 2024 · 0 comments

Comments

@huddlej
Copy link
Contributor

huddlej commented Aug 16, 2024

Description

As @tsibley originally noted:

Labels like [label="Show measurement threshold(s)"] should go thru our i18n framework (i18next) so they can be translated in the future.

label={t("Show measurement threshold(s)")}

Once they do, we can avoid the ugly "(s)" by using the standard pluralization/number agreement features, e.g. something like:

label={t("Show measurement threshold", {count: collection.thresholds.length})}

with corresponding translations, e.g. for en something like:

{
  "Show measurement threshold_one": "Show measurement threshold",
  "Show measurement threshold_others": "Show measurement thresholds",
}
@huddlej huddlej changed the title Use i18next translation features for measurements panel options (see @tsibley's comment). Use i18next translation features for measurements panel options Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant