Skip to content

Commit 679f50e

Browse files
authored
Conda check removed and seed parameters added for QUILT (#146)
* Remove conda from PR test * Add seed for stitch and quilt * Bump version in nf-core yml * Update changelog
1 parent 262290e commit 679f50e

File tree

5 files changed

+10
-8
lines changed

5 files changed

+10
-8
lines changed

.github/workflows/ci.yml

-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ jobs:
4040
- "24.04.2"
4141
- "latest-everything"
4242
profile:
43-
- "conda"
4443
- "docker"
4544
- "singularity"
4645
TEST_PROFILE:

.nf-core.yml

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
bump_version: null
2-
lint:
3-
subworkflow_changes: false
42
nf_core_version: 3.0.2
53
org_path: null
64
repository_type: pipeline
@@ -13,5 +11,5 @@ template:
1311
org: nf-core
1412
outdir: .
1513
skip_features: null
16-
version: 1.0dev
14+
version: 1.0.0
1715
update: null

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ Initial release of nf-core/phaseimpute, created with the [nf-core](https://nf-co
2323
- [#111](https://github.com/nf-core/phaseimpute/pull/111) - Add nf-test for all sbwf, wf, modules and functions.
2424
- [#131](https://github.com/nf-core/phaseimpute/pull/131) - Set normalisation as optional. Fix extension detection function. Add support for validation with vcf files. Concatenate vcf only if more than one file. Change `--phased` to `--phase` for consistency.
2525
- [#143](https://github.com/nf-core/phaseimpute/pull/143) - Improve contigs warning and error logging. The number of chromosomes contigs is summarized if above `max_chr_names`.
26+
- [#146](https://github.com/nf-core/phaseimpute/pull/146) - Add `seed` parameter for `QUILT`
2627

2728
### `Changed`
2829

@@ -58,6 +59,7 @@ Initial release of nf-core/phaseimpute, created with the [nf-core](https://nf-co
5859
- [#103](https://github.com/nf-core/phaseimpute/pull/103) - Update Glimpse2 phase, gunzip and multiqc
5960
- [#135](https://github.com/nf-core/phaseimpute/pull/135) - Impute by batch of 100 individuals by default using `--batch_size` parameter. All individuals BAM files are gathered and VCF are allowed for glimpse1 and glimpse2. Channel preprocessing of stitch is done in stitch subworkflow. Genotype likelihood computation for glimpse1 is now done outside of the subworkflow and merge the resulting vcf with all the samples. New test added to check batch separation. Improve `usage.md` documentation. Add validation to initialisation of the pipeline to ensure compatibility between tools, steps and the files provided by the user.
6061
- [#139](https://github.com/nf-core/phaseimpute/pull/139) - Update all nf-core modules
62+
- [#146](https://github.com/nf-core/phaseimpute/pull/146) - Remove conda CI check for PR due to nextflow error
6163

6264
### `Fixed`
6365

conf/steps/imputation_quilt.config

+1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ process {
2222

2323
// Impute quilt
2424
withName: 'NFCORE_PHASEIMPUTE:PHASEIMPUTE:BAM_IMPUTE_QUILT:QUILT_QUILT' {
25+
ext.args = "--seed=${params.seed}"
2526
ext.prefix = { "${meta.id}_batch${meta.batch}_${meta.chr}_${meta.chunk}.impute" }
2627
publishDir = [enabled: false]
2728
}

nextflow_schema.json

+6-4
Original file line numberDiff line numberDiff line change
@@ -154,6 +154,12 @@
154154
"mimetype": "text/csv",
155155
"schema": "/assets/schema_chunks.json",
156156
"pattern": "^\\S+\\.csv$"
157+
},
158+
"seed": {
159+
"type": "integer",
160+
"description": "Seed for random number generation in Stitch and Quilt software",
161+
"hidden": true,
162+
"default": 1
157163
}
158164
}
159165
},
@@ -426,10 +432,6 @@
426432
"description": "Arguments to customize STITCH run",
427433
"default": "",
428434
"properties": {
429-
"seed": {
430-
"type": "integer",
431-
"default": 1
432-
},
433435
"posfile": {
434436
"type": "string",
435437
"description": "Path to comma-separated file containing tab-separated files describing the variable positions to be used for imputation. Refer to the documentation for the `--posfile` argument of STITCH for more information.",

0 commit comments

Comments
 (0)