-
Notifications
You must be signed in to change notification settings - Fork 459
Add parabricks/fq2bam as alternative to fastq_preprocess_gatk #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.0.2. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
You'd need #1835 to be merged for tests |
Co-authored-by: Maxime U Garcia <[email protected]>
@maxulysse Did you discuss with @FriederikeHanssen about the nvidia containers and if we can use them like this? |
Shall we merge this and update the container separately? |
@famosab just check out your branch to work on some sentieon related refactoring with the new structure. I noticed this line: https://github.com/nf-core/sarek/blame/c9332a0a96414082d28b1d784c158a3f3dc3efbe/workflows/sarek/main.nf#L230 from you. Is there anything that should be cleaned up here before we merge in parabricks or possibly revert the first refactoring PR that enabled the parabricks implementation? |
@FriederikeHanssen Just remove that comment, that was me being stupid and I forgot to remove the comment 😁 I don't think there is anything else. |
Sorry, once again, I'm going to ask you if you could sync with dev. |
Replace nf-core#1729 by @edmundmiller <!-- Many thanks for contributing to nf-core/sarek! Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs). Remember that PRs should be made against the dev branch, unless you're preparing a pipeline release. Learn more about contributing: [CONTRIBUTING.md](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md) --> - [ ] This comment contains a description of changes (with reason). - [ ] If you've fixed a bug or added code that should be tested, add tests! - [ ] If you've added a new tool - have you followed the pipeline conventions in the [contribution docs](https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md) - [ ] If necessary, also make a PR on the nf-core/sarek _branch_ on the [nf-core/test-datasets](https://github.com/nf-core/test-datasets) repository. - [ ] Make sure your code lints (`nf-core pipelines lint`). - [ ] Ensure the test suite passes (`nextflow run . -profile test,docker --outdir <OUTDIR>`). - [ ] Check for unexpected warnings in debug mode (`nextflow run . -profile debug,test,docker --outdir <OUTDIR>`). - [ ] Usage Documentation in `docs/usage.md` is updated. - [ ] Output Documentation in `docs/output.md` is updated. - [ ] `CHANGELOG.md` is updated. - [ ] `README.md` is updated (including new tool citations and authors/contributors).
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).This adds the fq2bam tool from parabricks to the pipeline. Also renaming the gatk subworkflow to reflect that it does complete preprocessing and not only alignment.
Related to #1853.