Skip to content

fix versions+reports for CRAM_SAMPLEQC #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lindenb
Copy link
Contributor

@lindenb lindenb commented Jun 14, 2025

quick PR as seen in https://nfcore.slack.com/archives/C05V9FRJYMV/p1749936915649739

add reports and versions for CRAM_SAMPLEQC

@maxulysse
Copy link
Member

I'll include in #1917.
Thanks @lindenb

@@ -239,6 +239,9 @@ workflow SAREK {
params.skip_tools && params.skip_tools.split(',').contains('baserecalibrator'),
intervals_for_preprocessing)

versions = versions.mix(CRAM_SAMPLEQC.out.versions)
reports = reports.mix(CRAM_SAMPLEQC.out.reports)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally missed the reports 🤦

@maxulysse
Copy link
Member

Closing in favor of #1917, as I'm in the middle of re-generating snapshots already...
I totally missed the reports, so thanks a lot for that

@maxulysse maxulysse closed this Jun 15, 2025
@lindenb lindenb deleted the pl_fix branch June 15, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants