Skip to content

Commit cf5f9eb

Browse files
authored
Merge branch 'dev' into ci-nf-test
2 parents 250aace + 0058879 commit cf5f9eb

18 files changed

+183
-225
lines changed

.nf-core.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@ lint:
44
- .github/CONTRIBUTING.md
55
files_exist:
66
- .github/workflows/ci.yml
7+
nextflow_config:
8+
- config_defaults:
9+
- params.fastq_screen_references
710
nf_core_version: 3.2.0
811
repository_type: pipeline
912
template:

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,17 @@ Initial release of nf-core/seqinspector, created with the [nf-core](https://nf-c
2121
- [#53](https://github.com/nf-core/seqinspector/pull/53) Add FastQ-Screen database multiplexing and limit scope of nf-test in CI.
2222
- [#96](https://github.com/nf-core/seqinspector/pull/96) Added missing citations to citation tool
2323
- [#103](https://github.com/nf-core/seqinspector/pull/103) Configure full-tests
24+
- [#110](https://github.com/nf-core/seqinspector/pull/110) Update input schema to accept either tar file or directory as rundir, and fastq messages and patterns.
2425

2526
### `Fixed`
2627

2728
- [#71](https://github.com/nf-core/seqinspector/pull/71) FASTQSCREEN does not fail when multiple reads are provided.
2829
- [#99](https://github.com/nf-core/seqinspector/pull/99) Fix group reports for paired reads
30+
- [#107](https://github.com/nf-core/seqinspector/pull/107) Put SeqFU-stats section reports together
31+
- [#112](https://github.com/nf-core/seqinspector/pull/112) Making fastq_screen_references value to use parentDir
2932

3033
### `Dependencies`
3134

35+
- [#116](https://github.com/nf-core/seqinspector/pull/116) Update MultiQC to 1.28
36+
3237
### `Deprecated`

assets/schema_input.json

Lines changed: 18 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,31 @@
1717
"type": "string",
1818
"format": "file-path",
1919
"exists": true,
20-
"pattern": "^\\S+\\.f(ast)?q\\.gz$",
21-
"errorMessage": "FastQ file for reads 1 must be provided, cannot contain spaces and must have extension '.fq.gz' or '.fastq.gz'"
20+
"pattern": "\\.f(ast)?q\\.gz$",
21+
"errorMessage": "FastQ files for read 1 must be provided and must have extension '.fq.gz' or '.fastq.gz'"
2222
},
2323
"fastq_2": {
2424
"type": "string",
2525
"format": "file-path",
2626
"exists": true,
27-
"pattern": "^\\S+\\.f(ast)?q\\.gz$",
28-
"errorMessage": "FastQ file for reads 2 cannot contain spaces and must have extension '.fq.gz' or '.fastq.gz'"
27+
"pattern": "\\.f(ast)?q\\.gz$",
28+
"errorMessage": "FastQ files for read 2 are optional and must have extension '.fq.gz' or '.fastq.gz' if provided"
2929
},
3030
"rundir": {
31-
"type": "string",
32-
"format": "path",
33-
"exists": true,
34-
"errorMessage": "Run directory must be a path",
31+
"oneOf": [
32+
{
33+
"type": "string",
34+
"format": "file-path",
35+
"exists": true,
36+
"pattern": "\\.tar\\.gz$"
37+
},
38+
{
39+
"type": "string",
40+
"format": "directory-path",
41+
"exists": true
42+
}
43+
],
44+
"errorMessage": "Run directory must be a path or tar directory",
3545
"meta": ["rundir"]
3646
},
3747
"tags": {

conf/modules.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ process {
3131
publishDir = [
3232
path: { "${params.outdir}/seqfu_stats" },
3333
mode: params.publish_dir_mode,
34-
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
34+
saveAs: { filename -> filename.equals('versions.yml') ? null : "${meta.sample_id}_$filename" }
3535
]
3636
}
3737

modules.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
},
2929
"multiqc": {
3030
"branch": "master",
31-
"git_sha": "f0719ae309075ae4a291533883847c3f7c441dad",
31+
"git_sha": "7b50cb7be890e4b28cffb82e438cc6a8d7805d3f",
3232
"installed_by": ["modules"]
3333
},
3434
"seqfu/stats": {

modules/nf-core/multiqc/environment.yml

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/multiqc/main.nf

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/multiqc/tests/main.nf.test.snap

Lines changed: 9 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

modules/nf-core/multiqc/tests/tags.yml

Lines changed: 0 additions & 2 deletions
This file was deleted.

nextflow.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ params {
2121
igenomes_ignore = false
2222

2323
// Fastqscreen options
24-
fastq_screen_references = './assets/example_fastq_screen_references.csv'
24+
fastq_screen_references = "${projectDir}/assets/example_fastq_screen_references.csv"
2525

2626
// MultiQC options
2727
multiqc_config = null

nextflow_schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
},
9595
"fastq_screen_references": {
9696
"type": "string",
97-
"default": "./assets/example_fastq_screen_references.csv",
97+
"default": "${projectDir}/assets/example_fastq_screen_references.csv",
9898
"fa_icon": "fas fa-search",
9999
"description": "A .csv of reference genomes to be mapped against by FastQ Screen"
100100
}

tests/MiSeq.main.nf.test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
nextflow_pipeline {
22

3-
name "Test Workflow main.nf on MiSeq data"
3+
name "Test Workflow main.nf on MiSeq data with single end reads"
44
script "../main.nf"
55
tag "seqinspector"
66
tag "PIPELINE"
77

8-
test("MiSeq data test") {
8+
test("MiSeq data test (single end reads)") {
99

1010
when {
1111
config "./MiSeq.main.nf.test.config"

0 commit comments

Comments
 (0)