Skip to content

Commit 0646493

Browse files
committed
ci: resolve more review comments
Signed-off-by: Shengqi Chen <[email protected]>
1 parent 3c92517 commit 0646493

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

.github/workflows/example-app.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@ jobs:
2020
os: ubuntu-latest
2121
pre-build-script: ""
2222
build-args: ""
23-
debug-artifact-path: build/app/outputs/flutter-apk/app-debug.apk
24-
release-artifact-path: build/app/outputs/flutter-apk/app-release.apk
23+
debug-artifact-path: example/build/app/outputs/flutter-apk/app-debug.apk
24+
release-artifact-path: example/build/app/outputs/flutter-apk/app-release.apk
2525
- target: ios
2626
os: macos-latest
2727
pre-build-script: ""
2828
build-args: "--no-codesign"
2929
artifact-path: |
30-
build/ios/iphoneos/Runner.app
30+
example/build/ios/iphoneos/Runner.app
3131
3232
runs-on: ${{ matrix.os }}
3333
name: ${{ matrix.target }}-${{ matrix.variant }}
@@ -46,6 +46,7 @@ jobs:
4646

4747
- name: pre-build-script for ${{ matrix.target }}
4848
run: ${{ matrix.pre-build-script }}
49+
if: ${{ matrix.pre-build-script != '' }}
4950

5051
- run: flutter pub get
5152
working-directory: example/
@@ -58,5 +59,6 @@ jobs:
5859
with:
5960
name: example-${{ matrix.target }}-${{ matrix.variant }}
6061
path: |
61-
example/${{ matrix.debug-artifact-path }}
62-
example/${{ matrix.release-artifact-path }}
62+
${{ matrix.debug-artifact-path }}
63+
${{ matrix.release-artifact-path }}
64+
${{ matrix.artifact-path }}

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ jobs:
1818
- uses: actions/checkout@v6
1919
- uses: subosito/flutter-action@v2
2020
with:
21-
channel: ${{ matrix.channel }}
22-
cache: true
21+
channel: ${{ matrix.channel }}
22+
cache: true
2323
- run: dart pub get
2424
- run: dart format --output=none --set-exit-if-changed lib/
2525
- run: dart analyze

0 commit comments

Comments
 (0)