release 0.0.313 (#48)

* fix ASGI app return empty str * independent max payload size for ws --------- Co-authored-by: nggit <[email protected]>
nggit · Dec 2, 2023 · 8dea666 · 8dea666
1 parent c7821df
commit 8dea666
Show file tree

Hide file tree

Showing 9 changed files with 18 additions and 8 deletions.
diff --git a/alltests.py b/alltests.py
@@ -21,7 +21,8 @@
                     port=HTTP_PORT,
                     debug=False,
                     reload=True,
-                    client_max_body_size=73728))
+                    client_max_body_size=73728,
+                    ws_max_payload_size=73728))
     )
     processes.append(mp.Process(
         target=tremolo.run,

diff --git a/setup.py b/setup.py
@@ -7,7 +7,7 @@
 
 setup(
     name='tremolo',
-    version='0.0.312',
+    version='0.0.313',
     license='MIT',
     author='nggit',
     author_email='[email protected]',

diff --git a/tests/http_server.py b/tests/http_server.py
@@ -310,6 +310,6 @@ async def reload(request=None, **_):
 
 if __name__ == '__main__':
     app.run(HTTP_HOST, port=HTTP_PORT, debug=True, reload=True,
-            client_max_body_size=73728)
+            client_max_body_size=73728, ws_max_payload_size=73728)
 
 # END
diff --git a/tests/test_http_client.py b/tests/test_http_client.py
@@ -821,7 +821,8 @@ def test_reload(self):
                     port=HTTP_PORT,
                     debug=False,
                     reload=True,
-                    client_max_body_size=73728)
+                    client_max_body_size=73728,
+                    ws_max_payload_size=73728)
     )
 
     p.start()

diff --git a/tremolo/__init__.py b/tremolo/__init__.py
@@ -1,4 +1,4 @@
-__version__ = '0.0.312'
+__version__ = '0.0.313'
 
 from .tremolo import Tremolo  # noqa: E402
 from . import exceptions  # noqa: E402,F401

diff --git a/tremolo/__main__.py b/tremolo/__main__.py
@@ -37,6 +37,8 @@
         print('  --reload                  Enable auto reload on code changes')
         print('                            Intended for development')
         print('  --no-ws                   Disable built-in WebSocket support')
+        print('  --ws-max-payload-size     Maximum payload size for the built-in WebSocket')  # noqa: E501
+        print('                            Defaults to 2 * 1048576, or 2MiB')
         print('  --log-level               Defaults to "DEBUG". See')
         print('                            https://docs.python.org/3/library/logging.html#levels')  # noqa: E501
         print('  --download-rate           Limits the sending speed to the client')  # noqa: E501
@@ -77,6 +79,7 @@
                              '--download-rate',
                              '--upload-rate',
                              '--buffer-size',
+                             '--ws-max-payload-size',
                              '--client-max-body-size',
                              '--client-max-header-size',
                              '--max-queue-size',

diff --git a/tremolo/asgi_server.py b/tremolo/asgi_server.py
@@ -255,7 +255,9 @@ async def send(self, data):
                     )
 
                 if 'more_body' not in data or data['more_body'] is False:
-                    await self.response.write(b'', throttle=False)
+                    await self.response.write(
+                        b'', chunked=self._http_chunked, throttle=False
+                    )
                     self.response.close(keepalive=True)
 
                     self._read = None

diff --git a/tremolo/lib/websocket.py b/tremolo/lib/websocket.py
@@ -46,11 +46,11 @@ async def recv(self):
             payload_length = int.from_bytes(await self.request.recv(8),
                                             byteorder='big')
 
-            if payload_length > self.protocol.options['client_max_body_size']:
+            if payload_length > self.protocol.options['ws_max_payload_size']:
                 raise WebSocketServerClosed(
                     '%d exceeds maximum payload size (%d)' % (
                         payload_length,
-                        self.protocol.options['client_max_body_size']),
+                        self.protocol.options['ws_max_payload_size']),
                     code=1009
                 )
 

diff --git a/tremolo/tremolo.py b/tremolo/tremolo.py
@@ -335,6 +335,9 @@ async def _serve(self, host, port, **options):
                            worker=context,
                            debug=options.get('debug', False),
                            ws=options.get('ws', True),
+                           ws_max_payload_size=options.get(
+                               'ws_max_payload_size', 2 * 1048576
+                           ),
                            download_rate=options.get('download_rate', 1048576),
                            upload_rate=options.get('upload_rate', 1048576),
                            buffer_size=options.get('buffer_size', 16 * 1024),